Skip to content

Commit

Permalink
Prevent background scrolling when a modal is open (#38)
Browse files Browse the repository at this point in the history
  • Loading branch information
synox authored Jan 19, 2024
1 parent c6e3892 commit 0904dae
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
4 changes: 4 additions & 0 deletions blocks/modal/modal.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
body.modal-open {
overflow: hidden;
}

.modal dialog {
--dialog-border-radius: 16px;

Expand Down
7 changes: 6 additions & 1 deletion blocks/modal/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ export async function createModal(contentNodes) {
await loadBlock(block);
decorateIcons(closeButton);

dialog.addEventListener('close', () => block.remove());
dialog.addEventListener('close', () => {
document.body.classList.remove('modal-open');
block.remove();
});

block.append(dialog);
return {
Expand All @@ -48,6 +51,8 @@ export async function createModal(contentNodes) {
// Google Chrome restores the scroll position when the dialog is reopened,
// so we need to reset it.
setTimeout(() => { dialogContent.scrollTop = 0; }, 0);

document.body.classList.add('modal-open');
},
};
}
Expand Down

0 comments on commit 0904dae

Please sign in to comment.