Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds default includes for boilerplate content #47

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Adds default includes for boilerplate content #47

merged 3 commits into from
Nov 6, 2024

Conversation

msagolj
Copy link
Collaborator

@msagolj msagolj commented Sep 18, 2024 •
edited
Loading

Adds default includes for boilerplate content

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Sep 18, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@msagolj msagolj requested review from buuhuu and mhaack September 18, 2024 12:40
mhaack
mhaack reviewed Sep 18, 2024
View reviewed changes
paths.json Outdated
],
"includes": [
"/content/aem-boilerplate/",
"/content/dam/aem-boilerplate/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really include /content/dam by default? I would rater put that in docs only. As this is only needed if assets are published directly outsite of the page context.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly. Please remove that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@buuhuu
Copy link
Collaborator

buuhuu commented Sep 25, 2024

We must also remove the /conf/ setting from the assets folder.

@msagolj
Copy link
Collaborator Author

msagolj commented Sep 25, 2024

We must also remove the /conf/ setting from the assets folder.

@buuhuu are you referring to this in sites-franklin-examples ?
https://git.corp.adobe.com/CQ/sites-franklin/blob/main/content/sites-franklin-examples/jcr_root/content/dam/franklin-examples/.content.xml#L6

@msagolj msagolj requested a review from mhaack September 25, 2024 10:14
@buuhuu
Copy link
Collaborator

buuhuu commented Sep 26, 2024

are you referring to this in sites-franklin-examples ?
yes, @msagolj

@msagolj
Copy link
Collaborator Author

msagolj commented Nov 4, 2024

are you referring to this in sites-franklin-examples ?
yes, @msagolj

opened PR in sites-franklin:
https://git.corp.adobe.com/CQ/sites-franklin/pull/148

@msagolj msagolj changed the title Adds default includes for boilerplate content and boilerplate assets. Adds default includes for boilerplate content Nov 6, 2024
@msagolj msagolj merged commit 062b55f into main Nov 6, 2024
2 of 3 checks passed
@msagolj msagolj deleted the path-includes branch November 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buuhuu buuhuu Awaiting requested review from buuhuu

@mhaack mhaack Awaiting requested review from mhaack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msagolj @buuhuu @mhaack