SITES-16562 - [Xwalk] Open Universal Editor from Franklin Sidekick #17
Conversation
- port code from wknd project
- hide the default buttons
|
The although the description contains test URLs. |
scripts/sidekick.js
Outdated
| // hide the default buttons | ||
| const container = await getElement(sk, '.plugin-container'); | ||
| container.style.visibility = 'hidden'; | ||
| for (let i = 0; i < ['edit', 'reload', 'publish', 'delete', 'unpublish'].length; i += 1) { |
There was a problem hiding this comment.
use ['edit', 'reload', 'publish', 'delete', 'unpublish'].forEach(async (action) => { ... }) instead
There was a problem hiding this comment.
This was giving a linting error. That's why I used the for loop.
There was a problem hiding this comment.
but then at least define array as a variable and don't duplicate it.
There was a problem hiding this comment.
addressed in 5c102d6
scripts/scripts.js
Outdated
| @@ -142,6 +143,7 @@ function loadDelayed() { | |||
| // eslint-disable-next-line import/no-cycle | |||
| window.setTimeout(() => import('./delayed.js'), 3000); | |||
| // load anything that can be postponed to the latest here | |||
| initSidekick(); | |||
There was a problem hiding this comment.
better do an import('./sidekick.js').then(({ initSidekick }) => initSidekick()); here
that defers loading the script until after loadLazy finished. with the static import at the top scripts.js only executes with the script loaded and hence we impact LCP.
There was a problem hiding this comment.
addressed in 8fd5333
- address review feedback
- address review feedback
Fix SITES-16562
Test URLs:
Example:
