This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
Code was broken for new Dragonfly #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if data | ||
| [ | ||
| data, # can be a String, File, Pathname, Tempfile | ||
| resource_data['exif'] # the same meta Hash that was stored with write |
There was a problem hiding this comment.
Line is too long. [88/80]
Unnecessary spacing detected.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Please fix Hound comments and I'll merge it |
|
So I assume this was never merged in due to the Hound comments never being fixed? I came across the same problem myself today. If I fix up the comments would you still be open to merging it in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was broken for the new dragonfly version. It expected read and write methods, which were implemented. Tested and working with refinerycms.