max message size and header guards #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to remove the formats and all mentions of irssi
- Better formatting - No extra fields - Static assert
For some reason the fork I based off used an older version. This is not complete as much of it was never implemented in xchat upstream only irssi.
Removed the call to get_current_context_type in hook_privmsg, which checks for a current PM context, and the return if one is not found. This appears to have been mistakenly copied from hook_outgoing. The original code resulted in non-decrypted messages being received if the PM/query tab did not have focus. Closes TingPing#3
Introduced by e8f12f9 Closes TingPing#4
- Changes the call to otr_getcontext() in otr_send() such that it creates an OTR context if one does not exist. - Makes otr_send() have the same otr_getcontext() behavior as otr_receive(). - Updates corresponding error notice. - Resolves bug where a plugin user could not send regular unencrypted private messages to other users. Fixes TingPing#2 Closes TingPing#5
This doesn't affect releases
Fix typos discovered by codespell.
This get rid of two compiler warnings.
Note that this will require regenerating keys as they are not migrated. Closes TingPing#7
This is less than ideal but we can assert that the format string is safe as they are literals in hexchat-formats.c
This is less than ideal but we can assert that the format string is safe as they are literals in hexchat-formats.c
Some seem to count the pragma as the code line Closes TingPing#24
src/hexchat_otr.c:328:5: error: no previous prototype for ‘hexchat_plugin_deinit’ [-Werror=missing-prototypes]
local_install option relevant to TingPing#18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the
MAX_OTR_MSG_SIZEmacro to reflect the 512 byte limit imposed by the IRC standard RFC 2812, adds header guards, and updates some file commentary.