feat(huawei-csi-plugin): new chart containing the huawei csi plugin #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinicis
force-pushed
the
feature/huawei-csi-chart
branch
4 times, most recently
from
88c8c9c to
aa2ba46
Compare
this is the initial commit and the chart is more in a PoC state than fully engineered
sinicis
force-pushed
the
feature/huawei-csi-chart
branch
from
aa2ba46 to
8a27043
Compare
sinicis
requested review from
hairmare and
tongpu
and removed request for
a team
hairmare
approved these changes
Feb 25, 2021
eyenx
requested changes
Feb 26, 2021
sinicis
force-pushed
the
feature/huawei-csi-chart
branch
from
44e33b4 to
025d530
Compare
|
@eyenx There are also the CRDs which does not start with the |
CRDs do not need a prefix, or else other apps may not be able to use them. (ex: prometheus operator and its serviceMonitors) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial commit and the chart is more in a PoC state than fully engineered. So please be kind while reviewing ;-)
Our goal is that Huawei provides and maintains the docker image and helm chart in future so we can remove this chart together with the docker image from our repositories. If already created an issue on their GitHub project.