Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom pod annotations for Kubernetes runner #57

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

LouisVN
Copy link
Collaborator

@LouisVN LouisVN commented Oct 31, 2024

Allow conditional definition of custom annotations for the pod created by the Kubernetes runner such as:

  # Runner configuration
  config:
    # The kubernetes runner configuration
    kubernetes:
      # Kubernetes context to use
      context: mu-kube-context
      # Namespace to use
      namespace: env-staging
      # Annotations to attach to the pods 
      annotations:
        key1: value1
        key2: value2

This follows work around allows a new simple authentication and security layer (SASL) mechanism called AWS_MSK_IAM for the Amazon MSK service (see #56).
In some cases, it can notably be useful to define annotations in order to be able to assume IAM roles within Kubernetes, authorizing interaction with resources living in MSK.

this would allow core usage of such library, notably when using kubernetes runner
provide a way to configure annotations attached at the pod created by the kubernetes runner
document how to configure annotations attached at the pod created by the kubernetes runner
@LouisVN LouisVN merged commit f752916 into master Oct 31, 2024
1 check passed
@LouisVN LouisVN deleted the kubernetes-runner-pod-annotations branch November 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant