Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethon hostname fix #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nulldef
Copy link

@nulldef nulldef commented Oct 12, 2023

What is the purpose of this pull request?

Fix the incorrect hostname handling for the ethon-based libs.

For instance, calling GET https://demo.url/test

Before: { host: "https", method: "GET" }
After: { host: "demo.url", method: "GET" }

What changes did you make?

Added a check if the URL already starts with http

Is there anything you'd like reviewers to focus on?

nope 🤷‍♂️

Checklist

  • I've added tests for this change
  • I've added a Changelog entry

@nulldef
Copy link
Author

nulldef commented Nov 1, 2023

hey 👋
@aderyabin did you have a chance to take a look? :)

@Aubermean
Copy link

@aderyabin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants