Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks detected by running tests with AddressSanitizer #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix memory leaks detected by running tests with AddressSanitizer #9

wants to merge 3 commits into from

Conversation

maciej-pawlowski-opera
Copy link

Two memory leaks were found when running tests built with asan.

@abby-sergz
Copy link
Contributor

Hello @maciej-pawlowski-opera,

Thanks a lot for the contribution. We will process it, however we are currently restructuring our internal processes and therefore our reaction can be way too slow, despite the change might look pretty straightforward. I hope on your understanding.

FYI, this github repository is basically a mirror of https://gitlab.com/eyeo/adblockplus/libadblockplus, where the main development is happening. So, the pull request (merge request) should be rather sent onto the gitlab repository. However I would recommend to wait for a confirmation from eyeo GmbH beforehand.

@maciej-pawlowski-opera
Copy link
Author

Sure thing, I'll recreate this fix on gitlab when I have a minute and I'll let you figure out how to process it whenever you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciej-pawlowski-opera @abby-sergz @maciej-p-pawlowski