issue/517 Fixed missing matches in stdout

[oliverfoster]

fixes adapt-security/adapt-authoring#517

Fixed

• Handle outputs without Error in stdout.

[deltanetdan]

👍 fixes the TypeError issue, however AT build still fails as stderr returns Error: read ECONNRESET. Not sure if that should be a seperate issue?

[oliverfoster]

Does tom's version work any better? #164

[deltanetdan]

Afraid not, same error in stderr.

[cahirodoherty-learningpool]

👀

[oliverfoster]

@deltanetdan could you post the entire error please?

[KristofferBroberg]

Tried and got this error:
error.txt

[oliverfoster]

That's very weird. Will have another look.

[oliverfoster]

@taylortom i'm not quite sure why this is happening, the code in the adapt-cli seems fine, there's nothing coming out of the stderr or error objects for me, @Kristoffer has supplied a very weird error.txt that makes little sense.

I mean, it may be just that the error object and the stderr are not being passed through into the log output and so the problem isn't clear? But the compile seems to have completed correctly.

adapt-cli/lib/integration/AdaptFramework/build.js

Lines 30 to 36 in f9acaa5

	if(error || stderr) {
	const e = new Error('grunt tasks failed')
	e.cmd = cmd;
	e.raw = stdout.match(/>> Error:\s(.+)\s/)[1]
	return reject(e)
	}
	resolve()

[KristofferBroberg]

Perhaps @deltanetdan could attach his error output too? I recall getting something else at one point... it´s not unlikely that the error.txt above is due to my installation which is in a somewhat sloppy state.

[oliverfoster]

@KristofferBroberg could you try to replicate your issue using the above changes?

I want to see what's in those stderr and error variable.

[KristofferBroberg]

@oliverfoster Will do tonight as I don't have access to my computer right now.

[deltanetdan]

Apologies @oliverfoster , missed the 1st mention. Console and terminal attached
issue:517-console.txt
issue517-terminal.txt

[deltanetdan]

I can DM you the .har file if you want?

[KristofferBroberg]

@KristofferBroberg could you try to replicate your issue using the above changes?

I want to see what's in those stderr and error variable.

Tested:

source: null, stderr: 'Error: read ECONNRESET\n' + ' at TLSWrap.onStreamRead (node:internal/stream_base_commons:217:20) {\n' + ' errno: -54,\n' + " code: 'ECONNRESET',\n" + " syscall: 'read'\n" + '}\n' +
...a bunch of NPM notices

From what I can tell/guess my installation is corrupt and @danielstorey's input is more relevant for this issue.

[oliverfoster]

which version of node are you both using?

[oliverfoster]

I can DM you the .har file if you want?

yes please 👍

[KristofferBroberg]

which version of node are you both using?

16.14.0

[deltanetdan]

Node v16.14.2
MongoDB 4.4.10
AT 1.0.0-beta.1 (https://github.com/adapt-security/adapt-authoring)
adapt_framework 5.19.4

[oliverfoster]

nodejs/node#42154 (comment)

Could you both upgrade to the latest v16? See if that helps?

[oliverfoster]

I'll commit this for the moment and we'll come back to this on another ticket.

[KristofferBroberg]

nodejs/node#42154 (comment)

Could you both upgrade to the latest v16? See if that helps?

No luck!

[oliverfoster]

ECONNRESET issue #169

[deltanetdan]

Could you both upgrade to the latest v16? See if that helps?

Also no luck!