Use DateFormat to get the weekday labels #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using DateFormat the labels will change according to the device language
adamstyrc
reviewed
Mar 5, 2020
|
|
||
| class CalendarroWeekdayLabelsView extends StatelessWidget { | ||
| final DateTime monday = DateTime(2020, 01, 06); |
There was a problem hiding this comment.
Hey, I like the idea :) but I don't like hardcoding specific dates. Is there no other way to do it ?
There was a problem hiding this comment.
Yes, I agree that it's not ideal but unfortunately I don't know another way to make it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using DateFormat the labels will change according to the device's language