Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement cursor moving functionality #37

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Nov 9, 2024

dont merge

includes initialization of cursor moving functionality from #29 , and fully implements it

closes #29

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Nov 9, 2024

#34 needs to be reworked,

        self.buffer.chars[BUFFER_HEIGHT - 1][self.column_position].write(ScreenChar {
            ascii_character: b' ',
            color_code: self.color_code,
        });

will not work properly here.

@nnyyxxxx nnyyxxxx marked this pull request as draft November 9, 2024 11:25
@nnyyxxxx nnyyxxxx changed the title Cursor moving init implement cursor moving functionality Nov 9, 2024
@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Nov 9, 2024

#34 needs to be reworked,

        self.buffer.chars[BUFFER_HEIGHT - 1][self.column_position].write(ScreenChar {
            ascii_character: b' ',
            color_code: self.color_code,
        });

will not work properly here.

disregard this, fixed in a20603c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant