Skip to content

Commit

Permalink
fixed build explorejs lib which includes now explorejs-common
Browse files Browse the repository at this point in the history
in the future, to leverage webpack2 chunks optimization, we should include only our code and keep all vendor dependencies not included
if not, for example, where we make a library which has entrypoint with some api but has some included dependecies - all will be placed in one module??????? so propably webpack cannot split those dependent modules or I am wrong
  • Loading branch information
adam committed Apr 8, 2017
1 parent b9f9a56 commit 61bad61
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"lerna": "2.0.0-beta.38",
"lerna": "2.0.0-rc.1",
"packages": [
"packages/*"
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"eslint": "^3.18.0",
"eslint-loader": "1.6.1",
"hamjest": "^2.13.0",
"lerna": "2.0.0-beta.38",
"lerna": "^2.0.0-rc.1",
"sinon": "^1.4.0",
"sinon-chai": "^2.8.0",
"webpack": "2.2.1"
Expand Down
1 change: 1 addition & 0 deletions packages/explorejs-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"main": "lib/explorejs-common.js",
"scripts": {
"build": "webpack --env build --display-error-details",
"build:dev": "webpack --env dev --display-error-details",
"dev": "webpack --display-modules --progress --colors --watch --env dev",
"test": "mocha --compilers js:babel-core/register --colors ./test/**/*.js",
"test:watch": "mocha --compilers js:babel-core/register --colors -w ./test/**/*.js"
Expand Down
2 changes: 2 additions & 0 deletions packages/explorejs-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
"version": "0.0.0",
"description": "library to enable big-data in ui time-series components",
"main": "lib/explorejs-lib.js",
"jsnext:main": "es/explorejs-lib.js",
"scripts": {
"build": "webpack --env build --display-error-details",
"build:dev": "webpack --env dev --display-error-details",
"dev": "webpack --display-modules --progress --colors --watch --env dev",
"test": "mocha --compilers js:babel-core/register --colors ./test/**/*.test.js",
"test:watch": "mocha --compilers js:babel-core/register --colors -w ./test/**/*.test.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/explorejs-lib/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ const config = {
{
test: /(\.jsx|\.js)$/,
loader: 'babel-loader',
exclude: /(node_modules|bower_components)/
include: path.join(__dirname, 'src')
},
{
test: /(\.jsx|\.js)$/,
loader: 'eslint-loader',
exclude: /node_modules/
include: path.join(__dirname, 'src')
}
]
},
Expand Down

0 comments on commit 61bad61

Please sign in to comment.