-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to SocketPool #159
Conversation
@anecdata re-done with all the merges (including the SSL one). Would you be willing to test this again for me? |
I apologize for the hard review. With moving a few things at the top, it isn't a simple white space change with it going into the class. I promise I didn't change anything. |
This looks good, working for me with... Hardware config: Code: Verified at the router that the sessions are cycling through the three ethernet IP addresses in sync with the code. addendum: HTTPS is also working across all three ethernets. Not sure if it matters, but SSL works using either separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested with adafruit/Adafruit_CircuitPython_ConnectionManager#11 (review). Good to go pending any others with code review.
Same q I asked re ESP32SPI. If this is an incompatible change, then we'll need to change any Guide examples we have. If not, no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 matching changes also made in ConnectionManager
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.0.0 from 7.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#198 from justmobilize/convert-to-socketpool Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.0.0 from 6.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#159 from justmobilize/convert-to-socketpool Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 2.0.0 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#11 from justmobilize/esp32spi-and-wiznet5k-socketpool Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
For use with: adafruit/Adafruit_CircuitPython_ConnectionManager#11
Converting from the old
adafruit_wiznet5k/adafruit_wiznet5k_socket.py
toadafruit_wiznet5k/adafruit_wiznet5k_socketpool.py
to removeset_interface
and work more like a built-in SocketPool.This also allows one to use multiple WIZNET5K boards at the same time.
General example:
or with the new
ConnectionManager