-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socket.connect(): Auto-select UDP_MODE #201
Conversation
This improves compatibility with the standard socket module
@jepler this makes sense to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Tested by adafruit/Adafruit_CircuitPython_NTP#32 (comment).
Does this need to come along with some other change inside adafruit_connection_manager or elsewhere? I tried this branch on a PyPortal Titano with the currently released connection manager and the esp32spi_simpletest.py from requests library but I seem to consistently get this exception raised:
Maybe this is related to #198 |
I understand now. With the current connection manager pasted into the root of CIRCUITPY to override the frozen instance, I was able to test this successfully as well with that simpletest script. As an aside, it might be nice if circup were aware of the list of frozen modules per device so that it could give you a warning if / when you install a library that is not going to have any effect by default due to being overridden by a frozen one. |
@FoamyGuy I had asked at one point about frozen libs, and since the amount of devices were low, it was said it wasn't worth it. Also, it will install things in lib that are frozen, and then they don't get used... I had thought of adding a method to install in root to fix this as well. Happy to take this in if wanted |
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.1.1 from 8.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#201 from adafruit/connect_dgram_mode Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.5.0 from 1.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#38 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.2.0 from 1.1.27: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#26 from ContosChaos/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.5.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#34 from RossK1/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
This improves compatibility with the standard socket module
Not tested. Prompted by adafruit/Adafruit_CircuitPython_NTP#32