Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 (23.10.0) #268

Merged
merged 3 commits into from
Oct 4, 2023
Merged

🔖 (23.10.0) #268

merged 3 commits into from
Oct 4, 2023

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Oct 2, 2023

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for actualbudget-website ready!

Name Link
🔨 Latest commit c583363
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget-website/deploys/651c08cd9c0783000857a97b
😎 Deploy Preview https://deploy-preview-268.www.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions

This comment has been minimized.

Copy link
Member

@youngcw youngcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the flagged spelling errors are fine, unless you feel like you need to change "gitbuh" to "github" on #1692.

@github-actions

This comment has been minimized.

@MatissJanis
Copy link
Member Author

@check-spelling-bot apply updates.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@check-spelling-bot: Could not perform request.

The referenced report comment is hidden (outdated). This probably means the referenced report has been obsoleted by a more recent push & review. Did you mean to apply the most recent report (#268 (comment))?

See log for details.

@MatissJanis

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

⌛ check-spelling changes applied

As configured, the commit pushed by @check-spelling-bot to GitHub doesn't trigger GitHub workflows due to a limitation of the @github-actions system.

Users with the Admin role can address this for future interactions 🪄

Create a deploy key and secret

(
  set -e
  brand=check-spelling; repo='actualbudget/docs'; SECRET_NAME=CHECK_SPELLING
  cd "$(mktemp -d)"
  ssh-keygen -f "./$brand" -q -N "" -C "$brand key for $repo"
  gh repo deploy-key add "./$brand.pub" -R "$repo" -w -t "$brand-talk-to-bot"
  gh secret -R "$repo" set "$SECRET_NAME" < "./$brand"
)

Configure update job in workflow to use secret

If the .github/workflows/spelling.yml workflow Update PR job doesn't already have the check-spelling/with/ssh_key, then add them:

    name: Update PR
    ...
    steps:
    ...
    - name: apply spelling updates
      uses: ${action_ref:-check-spelling/check-spelling@...}
      with:
        checkout: true
+       ssh_key: "${{ secrets.CHECK_SPELLING }}"

To trigger another validation round and hopefully a ✅, please add a blank line, e.g. to .github/actions/spelling/expect.txt and commit the change.

@MatissJanis MatissJanis merged commit 4b49146 into master Oct 4, 2023
@MatissJanis MatissJanis deleted the release/23.10.0 branch October 4, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants