[BugFix] Space missing on create local account copy #3985
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
talkintomato
changed the title
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/desktop-client/src/components/modals/CreateAccountModal.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request introduces modifications to the The The user interface has been updated to provide better visual feedback during the account connection process. This includes disabling the connection button while accounts are being fetched and displaying a loading state. The text describing account linking has been refined to more clearly distinguish between European and North American bank account connections. A new type definition Possibly related PRs
Suggested Labels
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/desktop-client/src/components/modals/CreateAccountModal.tsx (1)
Line range hint
182-183: Consider moving state declaration to improve code organizationThe
loadingSimpleFinAccountsstate declaration appears after its usage in the JSX. Consider moving it to the top of the component with other state declarations for better code organization and maintainability.const [isSimpleFinSetupComplete, setIsSimpleFinSetupComplete] = useState< boolean | null >(null); + const [loadingSimpleFinAccounts, setLoadingSimpleFinAccounts] = useState(false); const onConnectGoCardless = () => { // ... existing code ... }; // ... other code ... let title = t('Add Account'); - const [loadingSimpleFinAccounts, setLoadingSimpleFinAccounts] = useState(false);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/3985.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/desktop-client/src/components/modals/CreateAccountModal.tsx(1 hunks)
🔇 Additional comments (2)
packages/desktop-client/src/components/modals/CreateAccountModal.tsx (2)
207-207: LGTM: Space correctly added to improve readability
The addition of {' '} properly fixes the missing space after "Create a local account" text, improving the readability of the local account creation description.
Line range hint 207-220: LGTM: Text content is well-structured and internationalized
The text content follows best practices:
- Proper use of i18n with t() function
- Clear explanation of local account functionality
- Helpful documentation link for file importing
|
Thanks for this! |
category: BugFix
authors: talkintomato
Previously ->
