Fix mobile navigation tabs disappearing on top bounce

[mbaeuerle]

The mobile navigation tabs are hidden whenever you scroll down, they reappear when scrolling up. This is intended behavior.
On a bounce at the top however they disappear erroneously. I guess due to the bounce which scrolls slightly back down.
The same appears at the bottom where a bounce back up makes the tabs reappear.

This only seems to be an issue on iOS. Could not test it on Android due to not owning a device. But I could not detect this behavior in Firefox with small viewport.

This solution prevents the hiding / opening of the nav tabs by checking if it's at the top / bottom.

Issue at the top:

Issue at the bottom:

Fixed:

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	beefae3
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6759c0c57c7394000809cba9
😎 Deploy Preview	https://deploy-preview-3962.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.47 MB → 5.47 MB (+74 B)	+0.00%

Changeset

File	Δ	Size
src/components/mobile/MobileNavTabs.tsx	📈 +74 B (+1.45%)	4.97 kB → 5.04 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.45 MB → 3.45 MB (+74 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/AppliedFilters.js	21.91 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	82.99 kB	0%
static/js/wide.js	241.46 kB	0%
static/js/ReportRouter.js	1.52 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.32 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.32 MB	0%

[joel-jeremy]

LGTM! Thanks for the fix! This doesn't seem to be an issue on Android.