✨ 'hasTags' should show only for notes #3902

lelemm · 2024-11-26T13:08:33Z

'hasTags' should show only for notes

netlify · 2024-11-26T13:08:47Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`1a82a6a`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67476a71c63d400008f23f35
😎 Deploy Preview	https://deploy-preview-3902.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-11-26T13:09:57Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.45 MB → 5.45 MB (-17 B)	-0.00%

Changeset

File	Δ	Size
`home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts`	📉 -17 B (-0.22%)	7.51 kB → 7.5 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	3.44 MB → 3.44 MB (-17 B)	-0.00%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/useAccountPreviewTransactions.js	1.68 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	82.93 kB	0%
static/js/AppliedFilters.js	21.32 kB	0%
static/js/wide.js	241.19 kB	0%
static/js/ReportRouter.js	1.52 MB	0%

github-actions · 2024-11-26T13:09:58Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.32 MB → 1.32 MB (-10 B)	-0.00%

Changeset

File	Δ	Size
`packages/loot-core/src/shared/rules.ts`	📉 -23 B (-0.23%)	9.88 kB → 9.86 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
kcab.worker.js	1.32 MB → 1.32 MB (-10 B)	-0.00%

Unchanged

No assets were unchanged

lelemm · 2024-11-26T13:58:42Z

/update-vrt

coderabbitai · 2024-11-26T14:00:55Z

Walkthrough

The pull request introduces modifications to the TYPE_INFO and FIELD_INFO constants in the packages/loot-core/src/shared/rules.ts file. Specifically, it removes the 'hasTags' operation from the ops array associated with the id type. This alteration impacts the validation logic for id fields, as the functions isValidOp and getValidOps will no longer recognize 'hasTags' as a valid operation. Additionally, the imported_payee field in the FIELD_INFO constant is updated to include 'hasTags' in its disallowedOps list. The overall structure of the code remains unchanged, with no new functions added or existing ones removed. The changes primarily focus on refining the constraints for specific fields and their interactions with defined operations.

Possibly related PRs

refactor: fill in basic types in rules.ts #3365: The changes in this PR involve modifications to the Rule class and its properties, which may interact with the validation logic affected by the removal of the 'hasTags' operation in the main PR.

Suggested labels

:sparkles: Merged

Suggested reviewers

MikesGlitch

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

UnderKoen

The change seems good! I do think with more conditions being added for specefic fields. That in addition to disallowedOps?: Set<RuleConditionOp>; we could add a additionalOps?: Set<RuleConditionOp>;. So we don't have to exclude all ops from field not important to them.

lelemm · 2024-11-26T23:45:25Z

The change seems good! I do think with more conditions being added for specefic fields. That in addition to disallowedOps?: Set<RuleConditionOp>; we could add a additionalOps?: Set<RuleConditionOp>;. So we don't have to exclude all ops from field not important to them.

good point

'hasTags' should show only for notes

380f9bb

actual-github-bot bot changed the title ~~✨ 'hasTags' should show only for notes~~ [WIP] ✨ 'hasTags' should show only for notes Nov 26, 2024

actual-github-bot bot added the 🚧 WIP label Nov 26, 2024

md

8f7a952

lelemm changed the title ~~[WIP] ✨ 'hasTags' should show only for notes~~ ✨ 'hasTags' should show only for notes Nov 26, 2024

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Nov 26, 2024

Update VRT

3ddde88

UnderKoen reviewed Nov 26, 2024

View reviewed changes

Merge branch 'master' into enhance/hasTags

1a82a6a

joel-jeremy approved these changes Nov 28, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Nov 28, 2024

joel-jeremy merged commit 5e7538f into actualbudget:master Dec 5, 2024
20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Dec 5, 2024

coderabbitai bot mentioned this pull request Dec 9, 2024

✨ Filter account with 'on budget' or 'off budget' #3891

Merged

lelemm deleted the enhance/hasTags branch December 16, 2024 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ 'hasTags' should show only for notes #3902

✨ 'hasTags' should show only for notes #3902

lelemm commented Nov 26, 2024

netlify bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

lelemm commented Nov 26, 2024

coderabbitai bot commented Nov 26, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

UnderKoen left a comment

lelemm commented Nov 26, 2024

✨ 'hasTags' should show only for notes #3902

✨ 'hasTags' should show only for notes #3902

Conversation

lelemm commented Nov 26, 2024

netlify bot commented Nov 26, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Nov 26, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Nov 26, 2024 • edited Loading

Bundle Stats — loot-core

lelemm commented Nov 26, 2024

coderabbitai bot commented Nov 26, 2024 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

UnderKoen left a comment

Choose a reason for hiding this comment

lelemm commented Nov 26, 2024

netlify bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

coderabbitai bot commented Nov 26, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)