Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix performance when navigating between budget/accounts #3882

Merged
merged 5 commits into from
Nov 24, 2024
Merged

🐛 Fix performance when navigating between budget/accounts #3882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4353b75
memo the bindingobj
MikesGlitch Nov 23, 2024
f3f51dc
release notes
MikesGlitch Nov 23, 2024
aa59fc9
fix
MikesGlitch Nov 23, 2024
53fd326
a bit heavy handed
MikesGlitch Nov 23, 2024
bf7a266
lint
MikesGlitch Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/desktop-client/src/components/spreadsheet/useSheetValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export function useSheetValue<
}
},
);
}, [sheetName, bindingObj.name, bindingObj.query]);
}, [sheetName, bindingObj.name, JSON.stringify(bindingObj.query)]);

return result.value;
}
6 changes: 6 additions & 0 deletions upcoming-release-notes/3882.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [MikesGlitch]
---

Fix performance regression around accounts and budget pages