Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Option Disappears Completely On Certain Screen Size #3880

Merged
merged 12 commits into from
Dec 8, 2024
Merged

Menu Option Disappears Completely On Certain Screen Size #3880

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
64692b0
remove use of View component
ericji1326 Nov 23, 2024
05a7dea
created a release note
ericji1326 Nov 23, 2024
a2cdfdd
rename release note to PR number not issue number
ericji1326 Nov 23, 2024
d494792
Merge branch 'master' into master
ericji1326 Nov 25, 2024
1fd314a
revert changes to check e2e tests
ericji1326 Nov 25, 2024
f3d4255
redo changes
ericji1326 Nov 25, 2024
c30f251
indentify exact styling issue
ericji1326 Nov 25, 2024
b2dae62
Merge branch 'master' into master
ericji1326 Nov 28, 2024
9a721f2
Merge branch 'master' into master
ericji1326 Dec 2, 2024
29ab591
Merge branch 'master' into master
ericji1326 Dec 6, 2024
a138b6f
use style instead of css
ericji1326 Dec 7, 2024
ce4aed4
Merge branch 'master' into master
ericji1326 Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/desktop-client/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@
min-width: 0;
}

.view-reset {
all: unset;
}

.js-focus-visible :focus:not(.focus-visible) {
outline: 0;
}
Expand Down
6 changes: 3 additions & 3 deletions packages/desktop-client/src/components/accounts/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function AccountHeader({
onMakeAsNonSplitTransactions={onMakeAsNonSplitTransactions}
/>
)}
<View>
<View className="view-reset">
{account && (
<>
<Button
Expand Down Expand Up @@ -427,7 +427,7 @@ export function AccountHeader({
</View>
</Button>
{account ? (
<View>
<View className="view-reset">
<MenuButton
aria-label="Account menu"
ref={triggerRef}
Expand Down Expand Up @@ -456,7 +456,7 @@ export function AccountHeader({
</Popover>
</View>
) : (
<View>
<View className="view-reset">
<MenuButton
aria-label="Account menu"
ref={triggerRef}
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/3880.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [ericji1326]
---

Fix bug where menu option icon disappearing completely on certain screen sizes.