Fix preview transactions not showing on all accounts page and aggregated accounts page (budgeted/offbudget)

[joel-jeremy]

Fixes #3863

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	bd8ea8f
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/673fa3bb41b5e600084853cd
😎 Deploy Preview	https://deploy-preview-3873.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.46 MB → 5.46 MB (+56 B)	+0.00%

Changeset

File	Δ	Size
src/hooks/useAccountPreviewTransactions.ts	📈 +56 B (+3.36%)	1.63 kB → 1.68 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/useAccountPreviewTransactions.js	1.63 kB → 1.68 kB (+56 B)	+3.36%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/AppliedFilters.js	21.32 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	82.72 kB	0%
static/js/wide.js	241.19 kB	0%
static/js/ReportRouter.js	1.52 MB	0%
static/js/index.js	3.44 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.32 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.32 MB	0%

[coderabbitai]

Walkthrough

The pull request introduces modifications to the useAccountPreviewTransactions hook located in packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts. The primary change involves altering the accountId property in the UseAccountPreviewTransactionsProps type from a required field to an optional one. This allows the hook to be called without an accountId. Additionally, the logic within the useAccountPreviewTransactions function has been updated. The check for accountId now occurs after verifying if the data is loading. If the loading state is true, the function will return an empty array for previewTransactions. If accountId is absent, it will return originalPreviewTransactions. The accountPreview function's signature and logic remain unchanged but are now conditionally invoked based on the presence of accountId. The overall structure of the hook and its return types are preserved.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure that schedules are displayed correctly in the all accounts page (#3863)	❌	The changes made in this PR do not address the issue regarding schedules not showing, as it focuses on the useAccountPreviewTransactions hook without any direct link to the schedules functionality.

Possibly related PRs

• Fixes #2703 - Fixes inaccurate running balance when hiding reconciled transactions #3603: This PR modifies the Account.tsx file, which may interact with the useAccountPreviewTransactions hook in the main PR, particularly in how transactions are filtered and displayed based on user preferences.
• Convert Mobile Transaction component to TransactionListItem + cleanup #3761: This PR involves changes to the mobile transaction components, which may relate to how transactions are handled in the context of account previews, especially with the introduction of new components that could utilize the updated useAccountPreviewTransactions logic.

Suggested labels

:sparkles: Merged

Suggested reviewers

• youngcw
• carkom

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint (1.23.1)

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eslint-plugin".

(The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eslint-plugin@latest --save-dev

The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c626fc2 and bd8ea8f.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/3873.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts (2 hunks)

🔇 Additional comments (3)

packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts (3)

14-14: LGTM: Type change aligns with supporting all accounts view

Making accountId optional is the correct approach to support both single account and all accounts views.

---

35-42: LGTM: Implementation correctly handles all accounts view

The changes properly handle both loading state and all accounts view, fixing the core issue of schedules not appearing.

---

39-41: Verify performance with large transaction sets

While the logic is correct, returning all preview transactions without filtering could impact performance for users with large transaction histories.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.