Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SimpleTransactionsTable.jsx to tsx #3870

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

@actual-github-bot actual-github-bot bot changed the title Convert SimpleTransactionsTable.jsx to tsx [WIP] Convert SimpleTransactionsTable.jsx to tsx Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 236dc9e
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/673f69353bf9080008d2775f
😎 Deploy Preview https://deploy-preview-3870.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the title [WIP] Convert SimpleTransactionsTable.jsx to tsx Convert SimpleTransactionsTable.jsx to tsx Nov 21, 2024
Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.46 MB → 5.46 MB (-158 B) -0.00%
Changeset
File Δ Size
src/components/transactions/SimpleTransactionsTable.tsx 🆕 +6.19 kB 0 B → 6.19 kB
src/components/transactions/SimpleTransactionsTable.jsx 🔥 -6.35 kB (-100%) 6.35 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.44 MB → 3.44 MB (-158 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/useAccountPreviewTransactions.js 1.63 kB 0%
static/js/AppliedFilters.js 21.32 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 82.72 kB 0%
static/js/wide.js 241.19 kB 0%
static/js/ReportRouter.js 1.52 MB 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.32 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.32 MB 0%

Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

Walkthrough

The pull request introduces significant modifications to the SimpleTransactionsTable.tsx component, focusing on enhancing type safety and refactoring transaction handling. Key changes include updating import statements to include new types such as CSSProperties and ReactNode, and replacing previous methods for fetching accounts and categories with hooks (useAccount, useCategory). The serializeTransaction function has been updated to explicitly type its parameters, ensuring that the transaction is of type TransactionEntity, and it now defaults the date to the current day in case of an invalid parsed date. The TransactionRow component has been refactored to use the new hooks for data fetching. Additionally, the props for the SimpleTransactionsTable component have been typed with SimpleTransactionsTableProps, and memoization of fields has been simplified. The renderItem function's parameter is now explicitly typed, and the dependencies for the memoized serializedTransactions have been expanded to include dateFormat. These changes collectively enhance type safety, improve error handling, and streamline data fetching.

Possibly related PRs

Suggested labels

::sparkles: Merged

Suggested reviewers

  • MikesGlitch
  • matt-fidd

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint (1.23.1)

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eslint-plugin".

(The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eslint-plugin@latest --save-dev

The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx (1)

181-181: Simplify conditional expression using optional chaining

You can simplify the conditional check for the selected prop by using optional chaining for better readability.

Apply this diff to make the change:

-            selected={selectedItems && selectedItems.has(item.id)}
+            selected={selectedItems?.has(item.id)}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c626fc2 and 236dc9e.

⛔ Files ignored due to path filters (1)
  • upcoming-release-notes/3870.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx (4 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx

[error] 183-183: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

🔇 Additional comments (1)
packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx (1)

36-36: 🛠️ Refactor suggestion

Reconsider handling of invalid dates in serializeTransaction

Setting date to the current day when the parsed date is invalid may lead to inaccurate transaction data. Consider handling invalid dates by setting date to null or retaining the original value to avoid misrepresenting the transaction date.

Apply this diff to adjust the handling:

 if (!isDateValid(parseISO(date))) {
-   date = monthUtils.currentDay();
+   date = null;
 }

Likely invalid or redundant comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants