Convert MergeUnusedPayeesModal.jsx to tsx #3866
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joel-jeremy
changed the title
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
WalkthroughThe pull request introduces significant modifications to the Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx (1)
121-124: Consider adding type safety to mapped JSX propsWhile the conversion is good, consider adding explicit type annotations to the mapped JSX props for better type safety:
-{payees.map(payee => ( +{payees.map((payee: PayeeEntity) => (
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
upcoming-release-notes/3866.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx(6 hunks)
🔇 Additional comments (6)
packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx (6)
Line range hint 1-24: LGTM! Well-structured type definitions
The TypeScript types are well-defined and properly imported. The MergeUnusedPayeesModalProps type correctly represents the component's props structure.
26-35: LGTM! Proper TypeScript component signature
The component signature is correctly typed with the new MergeUnusedPayeesModalProps interface, and the flashRef is properly typed as HTMLUListElement.
53-54: LGTM! Well-typed state initialization
The payees state is properly typed as PayeeEntity[] and efficiently initialized with the filter logic in the state initializer.
57-76: LGTM! Well-implemented merge callback
The onMerge callback is properly typed with TypeScript and correctly uses the useCallback hook with appropriate dependencies.
78-88: LGTM! Well-implemented merge and create rule callback
The onMergeAndCreateRule callback is properly typed and correctly uses the useCallback hook with appropriate dependencies.
90-92: LGTM! Proper null handling
The targetPayee lookup and null handling follow TypeScript best practices with appropriate type safety.
| const [payees] = useState<PayeeEntity[]>(() => | ||
| allPayees.filter(p => payeeIds.includes(p.id)), | ||
| ); |
No description provided.