Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix parameter formatting issues #3841

Merged
merged 2 commits into from
Nov 15, 2024
Merged

🐛 Fix parameter formatting issues #3841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bfcd24
fix some errors in translation format
MikesGlitch Nov 15, 2024
c665105
release notes
MikesGlitch Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/desktop-client/src/components/modals/EnvelopeBudgetMonthMenuModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export function EnvelopeBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budgets have all been set to last month’s budgeted amounts.',
'{{displayMonth}} budgets have all been set to last month’s budgeted amounts.',
{ displayMonth },
),
});
Expand All @@ -168,7 +168,7 @@ export function EnvelopeBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budgets have all been set to zero.',
'{{displayMonth}} budgets have all been set to zero.',
{ displayMonth },
),
});
Expand All @@ -189,7 +189,7 @@ export function EnvelopeBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budget templates have been applied.',
'{{displayMonth}} budget templates have been applied.',
{ displayMonth },
),
});
Expand All @@ -199,7 +199,7 @@ export function EnvelopeBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budget templates have been overwritten.',
'{{displayMonth}} budget templates have been overwritten.',
{ displayMonth },
),
});
Expand All @@ -209,7 +209,7 @@ export function EnvelopeBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} end-of-month cleanup templates have been applied.',
'{{displayMonth}} end-of-month cleanup templates have been applied.',
{ displayMonth },
),
});
Expand Down
8 changes: 4 additions & 4 deletions packages/desktop-client/src/components/modals/TrackingBudgetMonthMenuModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export function TrackingBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budgets have all been set to last month’s budgeted amounts.',
'{{displayMonth}} budgets have all been set to last month’s budgeted amounts.',
{ displayMonth },
),
});
Expand All @@ -170,7 +170,7 @@ export function TrackingBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budgets have all been set to zero.',
'{{displayMonth}} budgets have all been set to zero.',
{ displayMonth },
),
});
Expand All @@ -191,7 +191,7 @@ export function TrackingBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budget templates have been applied.',
'{{displayMonth}} budget templates have been applied.',
{ displayMonth },
),
});
Expand All @@ -201,7 +201,7 @@ export function TrackingBudgetMonthMenuModal({
close();
showUndoNotification({
message: t(
'{displayMonth} budget templates have been overwritten.',
'{{displayMonth}} budget templates have been overwritten.',
{ displayMonth },
),
});
Expand Down
6 changes: 3 additions & 3 deletions packages/loot-core/src/shared/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function getUploadError({
return t('Uploading the file failed. Check your network connection.');
default:
return t(
'An internal error occurred, sorry! Visit https://actualbudget.org/contact/ for support. (ref: {reason})',
'An internal error occurred, sorry! Visit https://actualbudget.org/contact/ for support. (ref: {{reason}})',
{ reason },
);
}
Expand Down Expand Up @@ -67,7 +67,7 @@ export function getDownloadError({ reason, meta, fileName }) {
default:
const info = meta && meta.fileId ? `, fileId: ${meta.fileId}` : '';
return t(
'Something went wrong trying to download that file, sorry! Visit https://actualbudget.org/contact/ for support. reason: {reason}{info}',
'Something went wrong trying to download that file, sorry! Visit https://actualbudget.org/contact/ for support. reason: {{reason}}{{info}}',
{ reason, info },
);
}
Expand Down Expand Up @@ -105,7 +105,7 @@ export function getSyncError(error, id) {
{ id },
);
} else {
return t('We had an unknown problem opening “{id}”.', { id });
return t('We had an unknown problem opening “{{id}}”.', { id });
}
}

Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/3841.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MikesGlitch]
---

Fix translations parameter formatting issues