Fix back button behavior after adding tx on mobile #3825
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
JukeboxRhino
changed the title
WalkthroughThe pull request modifies the Assessment against linked issues
Possibly related issues
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (2)
Line range hint
562-567: Consider adding error logging for undefined account caseWhile the fallback navigation works, it would be helpful to log when we hit the undefined account case to track potential issues.
if (account) { navigate(`/accounts/${account.id}`, { replace: true }); } else { + console.error('Account undefined when saving transaction:', accountId); // Handle the case where account is undefined navigate(-1); }
Line range hint
571-576: Consider tracking the UX inconsistency between mobile and webThe comment raises a valid point about the different warning behaviors between platforms. This UX inconsistency should be evaluated.
Would you like me to create a GitHub issue to track the discussion about aligning the reconciled transaction warning behavior between mobile and web platforms?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
upcoming-release-notes/3825.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx(1 hunks)
🔇 Additional comments (1)
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (1)
562-562: LGTM: Navigation fix correctly addresses the back button issue
The addition of { replace: true } properly fixes the regression by replacing the current history entry instead of adding to it, ensuring users don't return to the add transaction screen when pressing back.
#3549 introduced a regression by removing
{ replace: true }on the call tonavigate()when navigating to the account page after adding a new transaction. This PR fixes the behavior so the back button works as expected again.Link to breaking change
Closes #3712