🔧 Remove test file #3756

MikesGlitch · 2024-10-30T11:55:55Z

Noticed this on my #3631 PR. It uses the electron desktop bundle and runs things with it - It seems like an old test file.

Removing because it was causing confusion - I am about to start cleaning up the build process and I was wondering why it was using the desktop build.

netlify · 2024-10-30T11:56:11Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`378f041`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67221ecd83ca9200082033f0
😎 Deploy Preview	https://deploy-preview-3756.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-10-30T11:57:08Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.32 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/AppliedFilters.js	21.3 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	82.57 kB	0%
static/js/wide.js	232.16 kB	0%
static/js/ReportRouter.js	1.5 MB	0%
static/js/index.js	3.33 MB	0%

github-actions · 2024-10-30T11:57:09Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.27 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.27 MB	0%

coderabbitai · 2024-10-30T12:26:31Z

Walkthrough

The pull request involves the deletion of the file init-node.js from the packages/loot-core directory. This file previously contained functionality for initializing a budget management system, which included importing necessary modules such as path and node-fetch. The main function, init, was designed to accept a budgetPath, derive the directory and budget ID from it, and call the initEmbedded method from the bundle module to start the budget system. Additionally, a run function executed the initialization process with a hardcoded budget path, handled account information retrieval, and managed transaction creation with a delay before closing the budget. The removal of this file indicates a significant change in how the budget management system is initialized and operated, as it managed asynchronous operations and interactions with the bundle module.

Possibly related PRs

Reduce electron package size #3553: The changes in this PR involve modifications to the build process that integrate resources from the loot-core module, which is directly related to the functionality removed in the main PR that dealt with initializing a budget management system using loot-core.

Suggested labels

:sparkles: Merged

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 59835a3 and 378f041.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/3756.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/loot-core/init-node.js (0 hunks)

💤 Files with no reviewable changes (1)

packages/loot-core/init-node.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai · 2024-10-30T12:29:18Z

Walkthrough

The pull request involves the deletion of the file init-node.js from the packages/loot-core directory. This file was responsible for initializing a budget application by utilizing a specified budget path. It included imports for handling file paths and making network requests, and it defined two asynchronous functions: init and run. The init function was designed to extract the budget ID from the provided path and initialize the budget environment using the initEmbedded method from the bundle module. The run function executed the init function with a predefined budget path, retrieved account information, and processed a transaction, including a simulated delay before closing the budget. The removal of this file indicates a significant change in how the budget management system is set up and operated, as it directly impacted both initialization and transaction processing.

Possibly related PRs

Reduce electron package size #3553: The changes in this PR involve modifications to the build process that integrate resources from the loot-core module, which is directly related to the functionality of the deleted init-node.js file that initialized the budget application using the bundle module from loot-core.

Suggested labels

::sparkles: Merged

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 59835a3 and 378f041.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/3756.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/loot-core/init-node.js (0 hunks)

💤 Files with no reviewable changes (1)

packages/loot-core/init-node.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MikesGlitch added 3 commits October 30, 2024 11:36

remove unneeded file

d0a7c43

release notes

2ea8600

release notes

378f041

actual-github-bot bot added the 🚧 WIP label Oct 30, 2024

MikesGlitch marked this pull request as ready for review October 30, 2024 12:10

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Oct 30, 2024

MikesGlitch changed the title ~~Remove test file~~ 👷‍♂️ Remove test file Oct 30, 2024

MikesGlitch changed the title ~~👷‍♂️ Remove test file~~ 🔧 Remove test file Oct 30, 2024

youngcw approved these changes Oct 30, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Oct 30, 2024

MikesGlitch merged commit dc42504 into actualbudget:master Oct 31, 2024
19 of 20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🔧 Remove test file #3756

🔧 Remove test file #3756

MikesGlitch commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

coderabbitai bot commented Oct 30, 2024

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot commented Oct 30, 2024

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

🔧 Remove test file #3756

🔧 Remove test file #3756

Conversation

MikesGlitch commented Oct 30, 2024 • edited Loading

netlify bot commented Oct 30, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Oct 30, 2024

Bundle Stats — desktop-client

github-actions bot commented Oct 30, 2024

Bundle Stats — loot-core

coderabbitai bot commented Oct 30, 2024

Walkthrough

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot commented Oct 30, 2024

Walkthrough

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

MikesGlitch commented Oct 30, 2024 •

edited

Loading

netlify bot commented Oct 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

CodeRabbit Configuration File (`.coderabbit.yaml`)