Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ make templates classy and replace 🍝 code #3754

Merged
merged 36 commits into from
Nov 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
f0d10db
by check
youngcw Oct 25, 2024
5ee7257
minor changes and TS class migration
youngcw Oct 30, 2024
b8d19f2
good starting point
youngcw Oct 30, 2024
5a28390
very basic testing
youngcw Oct 30, 2024
9b1aef1
Merge branch 'youngcw/classy-templates' of github.com:actualbudget/ac…
youngcw Oct 30, 2024
8c57d53
fix
youngcw Oct 30, 2024
1821c13
basic overwrite of simple templates working
youngcw Oct 30, 2024
32d471c
mostly working. By and schedule don't work
youngcw Oct 30, 2024
7bb4dfa
Merge branch 'youngcw/classy-templates' of github.com:actualbudget/ac…
youngcw Oct 31, 2024
9553e7b
some cleanup, better async
youngcw Nov 1, 2024
2f929eb
add notifications
youngcw Nov 2, 2024
aa48f2a
add daily weekly limits
youngcw Nov 2, 2024
31edc84
by is working I think
youngcw Nov 2, 2024
b1e78b4
mostly working
youngcw Nov 2, 2024
a0fdfd4
some fixes, make faster
youngcw Nov 2, 2024
bc3000c
lint, note
youngcw Nov 2, 2024
87a7132
note
youngcw Nov 2, 2024
4f346bf
cleanup old stuff
youngcw Nov 2, 2024
d8fd63b
fix paths
youngcw Nov 2, 2024
8a76b2f
test fixes
youngcw Nov 2, 2024
10c891e
fix test
youngcw Nov 2, 2024
1bda7d2
fix note
youngcw Nov 2, 2024
c497c26
rabbit, and fix long goal
youngcw Nov 2, 2024
e5c7940
lint
youngcw Nov 2, 2024
04922ca
some fixes
youngcw Nov 3, 2024
f871248
more typing
youngcw Nov 3, 2024
1700cc8
fix save error
youngcw Nov 3, 2024
b0ec0d6
last bunny fixes
youngcw Nov 3, 2024
018a655
fix save, trim schedule names
youngcw Nov 3, 2024
e8fb817
lint
youngcw Nov 3, 2024
d688cc6
Merge branch 'master' into youngcw/classy-templates
youngcw Nov 3, 2024
c55a446
minor fixes
youngcw Nov 4, 2024
d9789cd
Merge branch 'youngcw/classy-templates' of github.com:actualbudget/ac…
youngcw Nov 4, 2024
a0c4326
fix that broken merge
youngcw Nov 4, 2024
e149f67
last fixes
youngcw Nov 4, 2024
875adba
lint
youngcw Nov 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
good starting point
youngcw committed Oct 30, 2024
commit b8d19f2c87fb1bd8254242b55d986726b340c813
Loading

Unchanged files with check annotations Beta

const result = await goalsSimple(
template,
limitCheck,
errors,

Check failure on line 18 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Expected 2 arguments, but got 7.
limit,
hold,
to_budget,
);
// Then
expect(result.to_budget).toBe(10000);

Check failure on line 26 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'to_budget' does not exist on type '{ increment: number; }'.
expect(result.errors).toHaveLength(0);

Check failure on line 27 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'errors' does not exist on type '{ increment: number; }'.
expect(result.limitCheck).toBe(true);

Check failure on line 28 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'limitCheck' does not exist on type '{ increment: number; }'.
expect(result.limit).toBe(10000);

Check failure on line 29 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'limit' does not exist on type '{ increment: number; }'.
expect(result.hold).toBe(false);

Check failure on line 30 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'hold' does not exist on type '{ increment: number; }'.
});
it('should return correct budget amount when limit set and balance from previous month left over', async () => {
const result = await goalsSimple(
template,
limitCheck,
errors,

Check failure on line 47 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Expected 2 arguments, but got 7.
limit,
hold,
to_budget,
);
// Then
expect(result.to_budget).toBe(8000);

Check failure on line 55 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'to_budget' does not exist on type '{ increment: number; }'.
expect(result.errors).toHaveLength(0);

Check failure on line 56 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'errors' does not exist on type '{ increment: number; }'.
expect(result.limitCheck).toBe(true);

Check failure on line 57 in packages/loot-core/src/server/budget/goals/goalsSimple.test.ts

GitHub Actions / typecheck

Property 'limitCheck' does not exist on type '{ increment: number; }'.
expect(result.limit).toBe(10000);
});