-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reconcile button on the account page. #3684
Merged
Merged
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
382e890
added reconcile button to account page
attyluccio 6d307e4
Merge branch 'actualbudget:master' into reconcile-button
attyluccio d773dc0
add Reconcile Button in the account page
attyluccio 2869480
added release note
attyluccio 961bd6a
updated VRT snapshots
attyluccio 9ab2f38
Merge branch 'actualbudget:master' into reconcile-button
attyluccio bf75d56
removed Reconcile option from Account menu
a7e173b
minimal reconcile button with tooltip and aria-label
attyluccio 185ab40
made the button minimal with tooltip and added vrt
attyluccio 2952956
missing unused import
attyluccio 9398fe3
fixed icon and button size
attyluccio f1b9c68
merged into master and fixed conflicts
attyluccio b658a93
fixed merge conflicts
attyluccio aadddf7
Merge branch 'master' into reconcile-button
attyluccio 6d921f7
hide reconcile button on all account and for budget page
attyluccio bd94fa3
fix lint from merged file
attyluccio 5b618df
Merge branch 'master' into reconcile-button
attyluccio cbd534c
changed reconcile button order
attyluccio 774a125
Merge branch 'reconcile-button' of github.com:attyluccio/actual into …
attyluccio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+601 Bytes
(100%)
...apshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+656 Bytes
(100%)
...apshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+661 Bytes
(100%)
...apshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+688 Bytes
(100%)
...s-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+676 Bytes
(100%)
...s-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+646 Bytes
(100%)
...s-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+293 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+514 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+491 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+327 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+364 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+323 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+275 Bytes
(100%)
...es-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+309 Bytes
(100%)
...es-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+306 Bytes
(100%)
...es-a-new-account-and-views-the-initial-balance-transaction-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5 Bytes
(100%)
...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+290 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-4-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+321 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-5-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+314 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-6-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+268 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+317 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+318 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+290 Bytes
(100%)
...ons.test.js-snapshots/Transactions-checks-the-page-visuals-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+319 Bytes
(100%)
...ons.test.js-snapshots/Transactions-checks-the-page-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+324 Bytes
(100%)
...ons.test.js-snapshots/Transactions-checks-the-page-visuals-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+281 Bytes
(100%)
...js-snapshots/Transactions-creates-a-split-test-transaction-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+328 Bytes
(100%)
...js-snapshots/Transactions-creates-a-split-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+279 Bytes
(100%)
...js-snapshots/Transactions-creates-a-split-test-transaction-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+270 Bytes
(100%)
....test.js-snapshots/Transactions-creates-a-test-transaction-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+317 Bytes
(100%)
....test.js-snapshots/Transactions-creates-a-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+325 Bytes
(100%)
....test.js-snapshots/Transactions-creates-a-test-transaction-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+256 Bytes
(100%)
...snapshots/Transactions-creates-a-transfer-test-transaction-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+291 Bytes
(100%)
...snapshots/Transactions-creates-a-transfer-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+306 Bytes
(100%)
...snapshots/Transactions-creates-a-transfer-test-transaction-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+290 Bytes
(100%)
...snapshots/Transactions-creates-a-transfer-test-transaction-4-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+325 Bytes
(100%)
...snapshots/Transactions-creates-a-transfer-test-transaction-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+357 Bytes
(100%)
...snapshots/Transactions-creates-a-transfer-test-transaction-6-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+380 Bytes
(100%)
...js-snapshots/Transactions-filters-transactions-by-category-7-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+379 Bytes
(100%)
...js-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+382 Bytes
(100%)
...js-snapshots/Transactions-filters-transactions-by-category-9-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+385 Bytes
(100%)
...est.js-snapshots/Transactions-filters-transactions-by-date-7-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+384 Bytes
(100%)
...est.js-snapshots/Transactions-filters-transactions-by-date-8-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+385 Bytes
(100%)
...est.js-snapshots/Transactions-filters-transactions-by-date-9-chromium-linux.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
category: Enhancements | ||
authors: [attyluccio] | ||
--- | ||
|
||
Add Reconcile button on account page |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the
title
attribute to theButton
component for correct tooltip displayThe
title
attribute on the<View>
component may not render a tooltip as expected. To ensure the tooltip appears when a user hovers over the button, move thetitle
attribute to the<Button>
component.Apply this diff to fix the issue:
Alternatively, consider using a
Tooltip
component if available in your UI library for better consistency and flexibility.📝 Committable suggestion