Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔖 (24.10.1) fix synced prefs #3596

Merged
merged 1 commit into from
Oct 8, 2024
Merged

🔖 (24.10.1) fix synced prefs #3596

merged 1 commit into from
Oct 8, 2024

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Oct 7, 2024 •
edited
Loading

@actual-github-bot actual-github-bot bot changed the title 🔖 (24.10.1) fix synced prefs [WIP] 🔖 (24.10.1) fix synced prefs Oct 7, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 85a0226
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/670417e6d3e3a00008747482
😎 Deploy Preview https://deploy-preview-3596.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 5.3 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 82.55 kB 0%
static/js/usePreviewTransactions.js 1.64 kB 0%
static/js/AppliedFilters.js 20.96 kB 0%
static/js/wide.js 225.26 kB 0%
static/js/ReportRouter.js 1.5 MB 0%
static/js/index.js 3.32 MB 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.19 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.19 MB 0%

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2024

Walkthrough

This pull request includes updates to the version numbers in the package.json files for three different packages: @actual-app/api, @actual-app/web, and desktop-electron. Each package's version has been incremented from 24.10.0 to 24.10.1. No other modifications to dependencies, scripts, or configurations are present in any of the package.json files. The changes are consistent across all three packages, solely focusing on the version number update.

Possibly related PRs

  • 🔖 (24.10.0) #3545: This PR is directly related as it also involves an update to the version number in the package.json file, specifically for the @actual-app/api package, changing from 24.10.0 to 24.10.1, similar to the main PR's version update.

Suggested labels

:sparkles: Merged

Suggested reviewers

  • MikesGlitch
  • joel-jeremy
  • matt-fidd
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d5e0b7d and 85a0226.

⛔ Files ignored due to path filters (4)
  • upcoming-release-notes/3544.md is excluded by !**/*.md
  • upcoming-release-notes/3566.md is excluded by !**/*.md
  • upcoming-release-notes/3573.md is excluded by !**/*.md
  • upcoming-release-notes/3574.md is excluded by !**/*.md
📒 Files selected for processing (3)
  • packages/api/package.json (1 hunks)
  • packages/desktop-client/package.json (1 hunks)
  • packages/desktop-electron/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • packages/api/package.json
  • packages/desktop-client/package.json
  • packages/desktop-electron/package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MatissJanis MatissJanis changed the title [WIP] 🔖 (24.10.1) fix synced prefs 🔖 (24.10.1) fix synced prefs Oct 7, 2024
This was referenced Oct 7, 2024
Merged
Merged
@csenel
Copy link

csenel commented Oct 8, 2024

Build is failing at release notes step because for releases, branch name has to start with release/.

@MatissJanis
Copy link
Member Author

Build is failing at release notes step because for releases, branch name has to start with release/.

Thanks! We publish patch releases so rarely that we don't really have a proper process for doing them. If I had used a release/ branch - that would trigger the automation to delete all the release notes files (which we don't want to do!).

@MatissJanis MatissJanis merged commit 85b3c57 into master Oct 8, 2024
19 of 20 checks passed
@MatissJanis MatissJanis deleted the matiss/v24.10.1 branch October 8, 2024 17:02
MatissJanis added a commit to actualbudget/docs that referenced this pull request Oct 8, 2024
@MatissJanis
🔖 (24.10.1) (#465)
22b6076 
- web: actualbudget/actual#3596
- server: actualbudget/actual-server#475
- docs: #465
@coderabbitai coderabbitai bot mentioned this pull request Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngcw youngcw youngcw approved these changes

@joel-jeremy joel-jeremy joel-jeremy approved these changes

Assignees
No one assigned
Labels
✨ Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatissJanis @csenel @joel-jeremy @youngcw