Fix issue #3252 remove extra space from category name

[junyuanz1]

This PR is trying to fix #3252 by running the trim() method on the category name before creating/updating the DB.

[coderabbitai]

Walkthrough

The changes in this pull request focus on improving the handling of category names in the category-create and category-update functions. Specifically, the modifications ensure that leading and trailing whitespace is removed from category names before they are inserted into or updated in the database. This adjustment aims to maintain consistency in category name processing.

Changes

File	Change Summary
packages/loot-core/src/server/main.ts	Trimmed whitespace from the name property in category creation and update handlers.

Assessment against linked issues

Objective	Addressed	Explanation
Trailing space in category name results in unmatched category during import (#[3252])	✅

Possibly related PRs

• Do not allow renaming to an empty category or group name #3463: Enhances renaming functionality by preventing empty category names, which relates to ensuring valid category names through whitespace trimming.

Suggested labels

:sparkles: Merged

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	54daaf3
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66f258a11a99510008a31710
😎 Deploy Preview	https://deploy-preview-3495.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.29 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/usePreviewTransactions.js	1.59 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/AppliedFilters.js	20.97 kB	0%
static/js/narrow.js	81.24 kB	0%
static/js/wide.js	225.27 kB	0%
static/js/ReportRouter.js	1.5 MB	0%
static/js/index.js	3.31 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.19 MB → 1.19 MB (+31 B)	+0.00%

Changeset

File	Δ	Size
packages/loot-core/src/server/main.ts	📈 +92 B (+0.15%)	61.1 kB → 61.19 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1.19 MB → 1.19 MB (+31 B)	+0.00%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

packages/loot-core/src/server/main.ts (1)

Line range hint 283-297: Consider additional improvements for robustness.

The changes effectively address the issue with extra spaces in category names. To further improve the robustness of the application, consider the following suggestions:

1. Review other parts of the codebase where category names are handled to ensure consistent trimming.
2. Add unit tests to verify the trimming behavior for both category creation and updates.
3. Consider creating a utility function for trimming category names to ensure consistent behavior and easier maintenance.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 48cdffb and 54daaf3.

Files ignored due to path filters (1)

• upcoming-release-notes/3495.md is excluded by !**/*.md

Files selected for processing (1)

• packages/loot-core/src/server/main.ts (2 hunks)

Additional comments not posted (2)

packages/loot-core/src/server/main.ts (2)

283-286: LGTM: Trimming category name addresses the issue.

This change effectively removes leading and trailing spaces from the category name before inserting it into the database. This modification directly addresses the issue mentioned in #3252, where extra spaces in category names were causing mismatches during the import process.

---

294-297: LGTM: Consistent trimming in category update.

This change applies the same trimming logic to the category name when updating an existing category. This ensures consistency in how category names are handled throughout the application, preventing issues with extra spaces in both new and updated categories.