@emotion/css as drop-in replacement for abandoned glamor library #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 47 files out of 129 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
force-pushed
the
@emotion/css
branch
3 times, most recently
from
1813ee4 to
335d399
Compare
joel-jeremy
changed the title
|
What does POC mean and how can I help test? |
@Jonathan-Fang Proof of concept :) Just testing out the app to find any styling issues as result of the change. Appreciate it! :) |
joel-jeremy
force-pushed
the
@emotion/css
branch
2 times, most recently
from
636090a to
0ca0cca
Compare
|
I've been running this a little, I've not found anything out of the ordinary, and VRT passing is a good sign |
joel-jeremy
force-pushed
the
@emotion/css
branch
from
8cec4b2 to
3268772
Compare
|
@matt-fidd Thanks for the help testing it out! Just wanted to make sure that this I don't miss anything so I would like to have 2 or more maintainers review this. I also wonder if Emotion JS is still the best option for us at the moment since the original decision (#701) was made a year ago. Thoughts? |
joel-jeremy
force-pushed
the
@emotion/css
branch
2 times, most recently
from
39813d5 to
333d119
Compare
youngcw
previously approved these changes
Oct 17, 2024
joel-jeremy
force-pushed
the
@emotion/css
branch
from
e00ae96 to
110f0f7
Compare
|
@youngcw @matt-fidd I had to rebase to master. Do you mind approving again? Thanks! :) |
matt-fidd
previously approved these changes
Oct 17, 2024
joel-jeremy
force-pushed
the
@emotion/css
branch
from
110f0f7 to
f9295b7
Compare
youngcw
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #701
Actual uses glamor as it's CSS library: https://github.com/threepointone/glamor. The project has been abandoned for 7-8 years now.
This PR attampts to use EmotionJS's @emotion/css package as a drop-in replacement for glamor. Most of the APIs are the same i.e.
css,cx, etc so hoping that not much breakage happens. This will need to be thoroughly tested in to ensure that.This also serves as an opportunity to discuss about our options when modernizing the CSS library since there are lots of new developments in this space e.g. zero-runtime CSS libraries, etc.
reactwg/react-18#110