Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:electron: Fix gocardless "Linking account" integration #3212

Merged

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Aug 7, 2024

Fixes: #3210

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 08082c8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66b37cb1acf39a0008f3fc42
😎 Deploy Preview https://deploy-preview-3212.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.81 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 77.55 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.55 kB 0%
static/js/wide.js 245.05 kB 0%
static/js/ReportRouter.js 1.24 MB 0%
static/js/index.js 3.08 MB 0%

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.14 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.14 MB 0%

@MikesGlitch MikesGlitch changed the title [WIP] :electron: Fix gocardless call - forked process didnt know its origin [WIP] :electron: Fix gocardless back linking Aug 7, 2024
@MikesGlitch MikesGlitch changed the title [WIP] :electron: Fix gocardless back linking [WIP] :electron: Fix gocardless bank linking Aug 7, 2024
@MikesGlitch MikesGlitch changed the title [WIP] :electron: Fix gocardless bank linking [WIP] :electron: Fix gocardless "Linking account" integration Aug 7, 2024
...options,
headers: {
...options?.headers,
origin: 'app://actual',
Copy link
Contributor Author

@MikesGlitch MikesGlitch Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was that the forked server process in electron isn't able to pass along the browser window information (like the origin etc) because it operates outside of that context. The gocardless endpoint needs the origin.

I think this has been broken for quite some time. The old version of the app had a server.html which it was loading in a separate browser window - it might have worked then because the server process was running in browser context. We moved away from that a long time ago.

If anyone can think of a better way to do this I'm all ears.

@MikesGlitch MikesGlitch marked this pull request as ready for review August 7, 2024 14:06
@actual-github-bot actual-github-bot bot changed the title [WIP] :electron: Fix gocardless "Linking account" integration :electron: Fix gocardless "Linking account" integration Aug 7, 2024
@MikesGlitch MikesGlitch merged commit 6a85f84 into actualbudget:master Aug 7, 2024
19 checks passed
@MikesGlitch MikesGlitch deleted the fix/electron-gocardless-call branch August 7, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Linking account using GoCardless fails when using Desktop app
2 participants