-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for goal template types #3183
Add unit tests for goal template types #3183
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
8c8255a
to
15cb3f8
Compare
15cb3f8
to
a1d0f93
Compare
4a68a7e
to
052b77c
Compare
69fd40d
to
62c77ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
This PR adds unit tests for the various goal template types, which helps address this issue #1686. I hope this will help to improve the robustness of the templates going forward.
For each goal template type, I have created a file containing the unit tests for that template type. I've tried to cover as many of the potential scenarios as possible, but there will definitely be some scenarios I haven't covered, this is just to get the ball rolling.
While writing these tests I have found some areas in the goal templates that we can refactor and improve, which I can address in subsequent PRs.