Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modal2 backdrop #3147

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Add Modal2 backdrop #3147

merged 4 commits into from
Jul 29, 2024

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jul 27, 2024

Resolves #3145

@actual-github-bot actual-github-bot bot changed the title Add Modal2 backdrop [WIP] Add Modal2 backdrop Jul 27, 2024
Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 33e06a6
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66a727df84399b0008d0960d
😎 Deploy Preview https://deploy-preview-3147.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.8 MB → 4.8 MB (+51 B) +0.00%
Changeset
File Δ Size
src/components/common/Modal2.tsx 📈 +51 B (+0.55%) 9.08 kB → 9.13 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.04 MB → 3.04 MB (+51 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.61 kB 0%
static/js/narrow.js 78.3 kB 0%
static/js/wide.js 277.31 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.14 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.14 MB 0%

@joel-jeremy joel-jeremy changed the title [WIP] Add Modal2 backdrop Add Modal2 backdrop Jul 27, 2024
@MatissJanis
Copy link
Member

I think the accounts VRT tests need to be updated. I'm actually surprised they aren't breaking in CI in this PR 🤔

@joel-jeremy
Copy link
Contributor Author

I think the accounts VRT tests need to be updated. I'm actually surprised they aren't breaking in CI in this PR 🤔

That's true. Maybe it only detects shifts in pixel position but not blur/brightness changes? Not sure.

@MatissJanis
Copy link
Member

Would you mind updating the screnshots? Other than that LGTM!

@joel-jeremy
Copy link
Contributor Author

@MatissJanis Turns out playwright cannot detect the difference when blurred by < 1px

@joel-jeremy joel-jeremy requested a review from MatissJanis July 29, 2024 05:36
@joel-jeremy joel-jeremy merged commit 2c26fa5 into master Jul 29, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the modal2-backdrop branch July 29, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: modals - missing backdrop
2 participants