Disable typography linter in tests

[jfdoming]

In #3044 the typography linter rule is applying to test files. Strings in test files aren't user-facing, so it doesn't make sense to apply this rule there.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	f51ab1b
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/669d65527669760008ad5203
😎 Deploy Preview	https://deploy-preview-3114.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.79 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	78 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/AppliedFilters.js	27.61 kB	0%
static/js/wide.js	277.06 kB	0%
static/js/ReportRouter.js	1.23 MB	0%
static/js/index.js	3.04 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.13 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.13 MB	0%

[youngcw]

I think it makes enough sense to disable that lint in test files. It would be good to ask some of the other maintainers too though.

[matt-fidd]

Make sense to disable IMO, the purpose of the rule (as written in the rule):

actual/packages/eslint-plugin-actual/lib/rules/typography.js

Line 13 in b432204

'Detects usage of straight quotes in potentially user-visible locations',

[matt-fidd]

LGTM

[MatissJanis]

Just a thought: maybe we should just disable it everywhere. There is no auto-fixer for this rule. So it's quite an annoying one.. and arguably it doesn't add much value.

[jfdoming]

Just a thought: maybe we should just disable it everywhere. There is no auto-fixer for this rule. So it's quite an annoying one.. and arguably it doesn't add much value.

I feel like it's good for consistency maybe... but agree that an auto-fixer would be really nice. I'll open an issue to create one.