Add filtering of group name to autocomplete for transactions #2861

Crazypkr1099 · 2024-06-09T14:44:40Z

Reference #1681

I am anticipating criticism, so I am all ears. If you have a better place to put this option, please let me know :) I just really need this option.

netlify · 2024-06-09T14:44:59Z

❌ Deploy Preview for actualbudget failed.

Name	Link
🔨 Latest commit	`7899853`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6671aee554676b0008699c59

github-actions · 2024-06-09T14:46:22Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.75 MB → 4.75 MB (+607 B)	+0.01%

Changeset

File	Δ	Size
`src/components/autocomplete/CategoryAutocomplete.tsx`	📈 +607 B (+6.43%)	9.21 kB → 9.81 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.02 MB → 3.02 MB (+607 B)	+0.02%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	75.73 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/AppliedFilters.js	20.25 kB	0%
static/js/wide.js	263.59 kB	0%
static/js/ReportRouter.js	1.23 MB	0%

github-actions · 2024-06-09T14:46:23Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.13 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.13 MB	0%

…099/actual into autoCompleteCategories

youngcw · 2024-06-09T14:52:33Z

The theme button on the top of the page was removed recently. It shows up in development but not production for color testing.

Crazypkr1099 · 2024-06-09T14:53:37Z

The theme button on the top of the page was removed recently. It shows up in development but not production for color testing.

Why was this removed???? it was a great place for it.

…099/actual into autoCompleteCategories

carkom · 2024-06-11T19:18:49Z

It looks pretty good. Can you remove all the code for the settings option as that is no longer relevant?

removed toggleable settings

yoyotogblo · 2024-06-15T13:00:18Z

Thanks for working on this!

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

MatissJanis

Usability works as expected. Thanks for working on this! 👍

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

upcoming-release-notes/2861.md

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx

…c to categoryautocomplete, used toSorted, used Usememo, added TS.

Co-authored-by: Robert Dyer <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]>

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

…099/actual into autoCompleteCategories

Co-authored-by: Matiss Janis Aboltins <[email protected]>

…099/actual into autoCompleteCategories

MatissJanis

LGTM! Thanks for your hard work on this!

(will wait for another maintainer to review before merging)

youngcw

Looks good

Crazypkr1099 and others added 3 commits June 6, 2024 23:45

Delete packages/desktop-client/e2e directory

2476e45

Delete packages/desktop-client/e2e directory

bbec585

Add toggleable option to autoCompleteCategories

d9570dc

github-actions bot changed the title ~~Add toggleable autoCompleteCategories to Settings~~ [WIP] Add toggleable autoCompleteCategories to Settings Jun 9, 2024

Merge branch 'master' into autoCompleteCategories

6d6c9fb

Crazypkr1099 changed the title ~~[WIP] Add toggleable autoCompleteCategories to Settings~~ Add toggleable autoCompleteCategories to Settings Jun 9, 2024

Crazypkr1099 and others added 3 commits June 9, 2024 10:47

Create 2861.md

341993d

Fixing typescript error & removing console.log

f451dc6

Merge branch 'autoCompleteCategories' of https://github.com/Crazypkr1…

0efa14d

…099/actual into autoCompleteCategories

Crazypkr1099 changed the title ~~Add toggleable autoCompleteCategories to Settings~~ [WIP] Add toggleable autoCompleteCategories to Settings Jun 9, 2024

Added themesetting back in

65b7083

Crazypkr1099 closed this Jun 10, 2024

Added filtering and separation for group name autocomplete

654f1bc

Crazypkr1099 changed the title ~~[WIP] Add toggleable autoCompleteCategories to Settings~~ [WIP] Add filtering of group name to autocomplete for transactions Jun 11, 2024

Crazypkr1099 reopened this Jun 11, 2024

Crazypkr1099 added 6 commits June 10, 2024 23:04

Merge branch 'master' into autoCompleteCategories

4247932

removed typescript error

0011172

Merge branch 'autoCompleteCategories' of https://github.com/Crazypkr1…

117e381

…099/actual into autoCompleteCategories

another typescript error fixed

36e9604

ts error

3b1c8b1

removed styling

7ee65b4

Crazypkr1099 added 3 commits June 11, 2024 15:59

Update 2861.md

e3745b0

Update prefs.d.ts

de439af

Update index.tsx

3106cf4

removed toggleable settings

removed isChanged passdown

a889c62

psybers reviewed Jun 15, 2024

View reviewed changes

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx Outdated Show resolved Hide resolved

psybers reviewed Jun 15, 2024

View reviewed changes

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx Outdated Show resolved Hide resolved

MatissJanis requested changes Jun 16, 2024

View reviewed changes

Crazypkr1099 and others added 4 commits June 17, 2024 18:04

Merge branch 'master' into autoCompleteCategories

88e5117

Added string followed by category name capability, moved sorting logi…

2c057ec

…c to categoryautocomplete, used toSorted, used Usememo, added TS.

Fix unnecessary changes

27646f4

Apply suggestions from code review

7899853

Co-authored-by: Robert Dyer <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]>

Crazypkr1099 requested review from MatissJanis and psybers June 18, 2024 16:00

Merge branch 'master' into autoCompleteCategories

4945d4e

MatissJanis reviewed Jun 18, 2024

View reviewed changes

psybers approved these changes Jun 18, 2024

View reviewed changes

Crazypkr1099 and others added 2 commits June 18, 2024 15:21

Fixed TS, sort, and memo to useCallback

2337a81

Merge branch 'master' into autoCompleteCategories

9beb69f

Crazypkr1099 requested a review from MatissJanis June 18, 2024 19:22

MatissJanis reviewed Jun 18, 2024

View reviewed changes

Crazypkr1099 and others added 3 commits June 18, 2024 15:43

fix tosorted -> sort

b5c40e7

Merge branch 'autoCompleteCategories' of https://github.com/Crazypkr1…

f042e4f

…099/actual into autoCompleteCategories

Apply suggestions from code review

527dd78

Co-authored-by: Matiss Janis Aboltins <[email protected]>

Crazypkr1099 requested a review from MatissJanis June 18, 2024 19:44

Crazypkr1099 and others added 3 commits June 18, 2024 15:54

fix typescript issue

32a4ecd

Merge branch 'autoCompleteCategories' of https://github.com/Crazypkr1…

5ed189f

…099/actual into autoCompleteCategories

Merge branch 'master' into autoCompleteCategories

63dafb9

MatissJanis approved these changes Jun 18, 2024

View reviewed changes

Crazypkr1099 requested a review from psybers June 18, 2024 20:02

psybers approved these changes Jun 18, 2024

View reviewed changes

youngcw approved these changes Jun 18, 2024

View reviewed changes

youngcw merged commit 437e202 into actualbudget:master Jun 18, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add filtering of group name to autocomplete for transactions #2861

Add filtering of group name to autocomplete for transactions #2861

Crazypkr1099 commented Jun 9, 2024 •

edited

Loading

netlify bot commented Jun 9, 2024 •

edited

Loading

github-actions bot commented Jun 9, 2024 •

edited

Loading

github-actions bot commented Jun 9, 2024 •

edited

Loading

youngcw commented Jun 9, 2024

Crazypkr1099 commented Jun 9, 2024

carkom commented Jun 11, 2024

yoyotogblo commented Jun 15, 2024

MatissJanis left a comment

MatissJanis left a comment

youngcw left a comment

Add filtering of group name to autocomplete for transactions #2861

Add filtering of group name to autocomplete for transactions #2861

Conversation

Crazypkr1099 commented Jun 9, 2024 • edited Loading

netlify bot commented Jun 9, 2024 • edited Loading

❌ Deploy Preview for actualbudget failed.

github-actions bot commented Jun 9, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jun 9, 2024 • edited Loading

Bundle Stats — loot-core

youngcw commented Jun 9, 2024

Crazypkr1099 commented Jun 9, 2024

carkom commented Jun 11, 2024

yoyotogblo commented Jun 15, 2024

MatissJanis left a comment

Choose a reason for hiding this comment

MatissJanis left a comment

Choose a reason for hiding this comment

youngcw left a comment

Choose a reason for hiding this comment

Crazypkr1099 commented Jun 9, 2024 •

edited

Loading

netlify bot commented Jun 9, 2024 •

edited

Loading

github-actions bot commented Jun 9, 2024 •

edited

Loading

github-actions bot commented Jun 9, 2024 •

edited

Loading