Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some additional incorrect types #2676

Merged
merged 2 commits into from
May 4, 2024
Merged

Fix some additional incorrect types #2676

merged 2 commits into from
May 4, 2024

Conversation

twk3
Copy link
Contributor

@twk3 twk3 commented Apr 27, 2024

  • This is part of working towards having enough correct types to be able to run tsc on our packed api without error.
  • Working towards being able to ship types for the api in the package

Related to #2559

- This is part of working towards having enough correct types to be able to run tsc on our packed api without error.
- Working towards being able to ship types for the api in the package
@github-actions github-actions bot changed the title Fix some additional incorrect types [WIP] Fix some additional incorrect types Apr 27, 2024
Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 27c1732
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/662d3c57f6478a0008b731b2
😎 Deploy Preview https://deploy-preview-2676.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 27, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.68 MB → 4.68 MB (+31 B) +0.00%
Changeset
File Δ Size
src/components/ThemeSelector.tsx 📈 +31 B (+2.23%) 1.36 kB → 1.39 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.99 MB → 2.99 MB (+31 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.41 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.68 kB 0%
static/js/wide.js 263.53 kB 0%
static/js/ReportRouter.js 1.2 MB 0%

Copy link
Contributor

github-actions bot commented Apr 27, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@twk3 twk3 changed the title [WIP] Fix some additional incorrect types Fix some additional incorrect types Apr 27, 2024
@twk3 twk3 merged commit 2178da0 into master May 4, 2024
19 checks passed
@twk3 twk3 deleted the twk3/ts-api-fixes-round-4 branch May 4, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants