🔥 stripping out plaid integration #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MatissJanis
commented
Apr 16, 2024
| @@ -62,49 +23,3 @@ export async function findOrCreateBank(institution, requisitionId) { | |||
|
|
|||
| return bankData; | |||
| } | |||
|
|
|||
| export async function addGoCardlessAccounts( | |||
MatissJanis
commented
Apr 16, 2024
| @@ -720,21 +701,6 @@ handlers['simplefin-accounts-link'] = async function ({ | |||
| return 'ok'; | |||
| }; | |||
|
|
|||
| handlers['gocardless-accounts-connect'] = async function ({ | |||
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged No assets were unchanged |
joel-jeremy
approved these changes
Apr 17, 2024
trafico-bot
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripping out the old Plaid integration that was never working in the open source version.
Nobody has picked it up in >1yr. Furthermore - I believe the code has gotten quite outdated, so it will be easier to start from scratch with the example of gocardless/simplefin.
Plaid was partially stripped in this PR, but now I'm finishing the job.