Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low #2597

Merged
merged 10 commits into from
Apr 16, 2024

Conversation

ttlgeek
Copy link
Contributor

@ttlgeek ttlgeek commented Apr 13, 2024

Stop cash flow card labels from getting cutting off if bar height is too low.

Screenshots:

Case when bar is tall enough for labels:

image

Case when bar is too low:

image

@github-actions github-actions bot changed the title fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low [WIP] fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit de33ea7
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/661e9bfc424bb2000875d007
😎 Deploy Preview https://deploy-preview-2597.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 13, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.64 MB → 4.64 MB (+611 B) +0.01%
Changeset
File Δ Size
src/components/reports/reports/CashFlowCard.jsx 📈 +611 B (+13.99%) 4.26 kB → 4.86 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.19 MB → 1.19 MB (+611 B) +0.05%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/narrow.js 56.68 kB 0%
static/js/wide.js 262.74 kB 0%
static/js/index.js 2.97 MB 0%

Copy link
Contributor

github-actions bot commented Apr 13, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@ttlgeek ttlgeek changed the title [WIP] fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low Apr 13, 2024
@ttlgeek ttlgeek changed the title fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low [WIP] fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low Apr 13, 2024
@ttlgeek ttlgeek changed the title [WIP] fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low fix(#2575): Stop cash flow card labels from getting cutting off if bar height is too low Apr 14, 2024
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatissJanis MatissJanis merged commit 1e46271 into actualbudget:master Apr 16, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✅ Approved ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review ✨ Merged Pull Request has been merged successfully labels Apr 16, 2024
@ttlgeek ttlgeek deleted the fix-2575 branch April 16, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Income Label for Cash Flow Report Can Be Cut Off
2 participants