Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Y axis values of net worth graph when privacy mode i… #2594

Merged
merged 5 commits into from
Apr 13, 2024

Conversation

ttlgeek
Copy link
Contributor

@ttlgeek ttlgeek commented Apr 12, 2024

Hide Y axis values of net worth graph when privacy mode is enabled.

Closes #2563

Screenshot:

image

@github-actions github-actions bot changed the title Hide Y axis values of net worth graph when privacy mode i… [WIP] Hide Y axis values of net worth graph when privacy mode i… Apr 12, 2024
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 8e330ad
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6619b009b850cf0008a996f6
😎 Deploy Preview https://deploy-preview-2594.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.62 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 202.67 kB 0%
static/js/real-module.js 22.09 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/import.js 118.98 kB 0%
static/js/wide.js 371.51 kB 0%
static/js/ReportRouter.js 1.18 MB 0%
static/js/index.js 2.56 MB 0%

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@ttlgeek ttlgeek changed the title [WIP] Hide Y axis values of net worth graph when privacy mode i… Hide Y axis values of net worth graph when privacy mode i… Apr 12, 2024
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatissJanis MatissJanis merged commit 9aeab0f into actualbudget:master Apr 13, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Net Worth Y Axis values aren't removed in privacy mode
2 participants