Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Typescript migration: Convert accounts.jsx to accounts.tsx #2584

Closed
wants to merge 9 commits into from

Conversation

IzStriker
Copy link
Contributor

@IzStriker IzStriker commented Apr 11, 2024

#1483
Any feedback would be much appreicated.
(bigger than I hoped it would be, but I guess one file at a time)

@trafico-bot trafico-bot bot added the 🚧 WIP label Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 58a0853
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/661a32388be9640008d3ceb7
😎 Deploy Preview https://deploy-preview-2584.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.62 MB → 4.62 MB (+668 B) +0.01%
Changeset
File Δ Size
src/components/accounts/Account.tsx 🆕 +44.57 kB 0 B → 44.57 kB
package.json 📈 +30 B (+1.07%) 2.74 kB → 2.77 kB
src/components/reports/graphs/NetWorthGraph.tsx 📉 -62 B (-1.11%) 5.46 kB → 5.4 kB
src/components/accounts/Account.jsx 🔥 -43.88 kB (-100%) 43.88 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 371.51 kB → 372.19 kB (+700 B) +0.18%
static/js/index.js 2.56 MB → 2.56 MB (+30 B) +0.00%

Smaller

Asset File Size % Changed
static/js/ReportRouter.js 1.18 MB → 1.18 MB (-62 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 202.67 kB 0%
static/js/real-module.js 22.09 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/import.js 118.98 kB 0%

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant