Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron: Fix load backup functionality #2580

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Apr 10, 2024

The "load backup" feature isn't working in Electron - it throws a fatal error.

This is because the menu item isn't passing in the budget ID related to the backup (required parameter).

The fix is to pass the budget ID into the menu item and push the load-backup modal with it.

Error:

TypeError: Cannot read properties of undefined (reading 'budgetId') at app://actual/static/js/index.h17Pcr58.js:202:122692 at Array.map (<anonymous>) at mxe (app://actual/static/js/index.h17Pcr58.js:202:121619) at Gx

image

This is it working:
image

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 851e163
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/661989d47f51e700082c6e38
😎 Deploy Preview https://deploy-preview-2580.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.62 MB → 4.62 MB (-2 B) -0.00%
Changeset
File Δ Size
src/components/App.tsx 📉 -2 B (-0.04%) 4.38 kB → 4.38 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 2.56 MB → 2.56 MB (-2 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 202.67 kB 0%
static/js/real-module.js 22.09 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/import.js 118.98 kB 0%
static/js/wide.js 371.51 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@MikesGlitch MikesGlitch marked this pull request as ready for review April 10, 2024 19:35
@MikesGlitch MikesGlitch changed the title Fix load backup functionality for electron Electron: Fix load backup functionality Apr 10, 2024
@MikesGlitch MikesGlitch force-pushed the fix/backup-electron branch 2 times, most recently from f328051 to 9819986 Compare April 12, 2024 09:02
@MikesGlitch MikesGlitch force-pushed the fix/backup-electron branch from 9819986 to 851e163 Compare April 12, 2024 19:21
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@MatissJanis MatissJanis merged commit eed6105 into actualbudget:master Apr 12, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 12, 2024
@MikesGlitch MikesGlitch deleted the fix/backup-electron branch April 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants