Consistent modal paddings #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
changed the title
joel-jeremy
force-pushed
the
modal-paddings
branch
from
0b33288 to
d99a642
Compare
joel-jeremy
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joel-jeremy
force-pushed
the
modal-paddings
branch
2 times, most recently
from
03b3274 to
b4f15fe
Compare
joel-jeremy
commented
Apr 17, 2024
| @@ -23,26 +23,32 @@ export function ReportBudgetSummaryModal({ | |||
| }: ReportBudgetSummaryModalProps) { | |||
| const currentMonth = monthUtils.currentMonth(); | |||
| return ( | |||
| <Modal title="Budget Summary" {...modalProps}> | |||
| {() => ( | |||
| @@ -78,28 +78,34 @@ export function RolloverBudgetSummaryModal({ | |||
| }; | |||
|
|
|||
| return ( | |||
| <Modal title="Budget Summary" {...modalProps}> | |||
| {() => ( | |||
| borderRadius: '6px', | ||
| }} | ||
| > | ||
| {() => ( |
| @@ -28,45 +28,51 @@ export function SwitchBudgetTypeModal({ | |||
| } | |||
| : {}; | |||
| return ( | |||
| <Modal title="Switch budget type?" {...modalProps}> | |||
| {() => ( | |||
| borderRadius: '6px', | ||
| }} | ||
| > | ||
| {() => ( |
| borderRadius: '6px', | ||
| }} | ||
| > | ||
| {() => ( |
| borderRadius: '6px', | ||
| }} | ||
| > | ||
| {() => ( |
| borderRadius: '6px', | ||
| }} | ||
| > | ||
| {() => ( |
joel-jeremy
force-pushed
the
modal-paddings
branch
from
b4f15fe to
4ce0e68
Compare
MatissJanis
reviewed
Apr 19, 2024
| @@ -42,11 +42,10 @@ export function AccountAutocompleteModal({ | |||
| focusAfterClose={false} | |||
| {...modalProps} | |||
| onClose={_onClose} | |||
| padding={0} | |||
| padding={10} | |||
There was a problem hiding this comment.
❓ question: would it make sense to move the padding=10 inside the Modal component as the default value? Seems like it's used universally almost everywhere now.
There was a problem hiding this comment.
Also style = { flex: 1, borderRadius: '6px' }
joel-jeremy
force-pushed
the
modal-paddings
branch
from
4ce0e68 to
d3e3a5e
Compare
MatissJanis
previously approved these changes
Apr 22, 2024
joel-jeremy
force-pushed
the
modal-paddings
branch
from
804abbc to
f9d8cd6
Compare
MatissJanis
previously approved these changes
Apr 22, 2024
MatissJanis
approved these changes
Apr 22, 2024
trafico-bot
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the consistent paddings for modals