Show sync indicator in account header #2560
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
psybers
changed the title
|
Cool idea. But we have a small problem: when clicking "edit" the account name jumps to the left. Could we make the edit box stay in the same position as the account name? I believe we could just move the sync indicator outside the /edit/ boundaries and that would solve it. |
|
I was aware it 'jumped' left. I assumed, since the box is not sized to the string (try editing a name that is long), that it's moving would be ok. Even with short names, the box is not lined up perfectly with the label so there is a bit of wiggle. If you think that is a problem though, I can easily fix it. |
|
This is the current behavior: 
|
|
(And just to clarify, the behavior I implemented hides the indicator while editing. It is not that the box is on top of it.) |
|
I fixed that issue so the indicator stays put and the edit box does not 'jump'. As a side effect, I also fixed the slight 'wiggle' the box had when showing/hiding (even for accounts without an indicator). While I am in here would it also make sense to try and have the edit box enlarge to fit its contents for longer names? |
|
I could set the input Most will have some extra space at the end, as many characters are not as wide as a |
|
Without changing the width: With changing the width: |
|
It might make sense to ensure minimum width, e.g. 10 characters |
|
Sorry for the slow answer. I think this sample is ideally what we would want: #2560 (comment) If it's not technically overengineered to implement it - would you mind doing it? Otherwise your current solution is also OK and I'm happy to merge it as-is. |
|
@MatissJanis No it is a very simple fix. Just pushed. |
trafico-bot
bot
added
✨ Merged
Currently, sync indicators are only shown for desktop in the accounts list on the left sidebar. If you select a single account and ask to sync it, the indicator on the left is not visible for that account (since it is selected):
Thus you will not know if the sync failed (until you click to another account):
This PR updates to show the indicator in the header next to the account name:
For any accounts not sync'd (or "All Accounts" etc.) it simply shows no indicator: