Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Update TransactionEdit conponent onEdit function to use serialized transactions #2555

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Apr 5, 2024

Removed need to serialize transaction and remove the old comment saying we don't have access to serialized transactions. Also renamed some transaction variables to unserializedTransaction to avoid confusion with the other serialized transaction variables

@github-actions github-actions bot changed the title [Maintenance] Update onEdit to use serialized transactions [WIP] [Maintenance] Update onEdit to use serialized transactions Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 9c8e372
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66103857c1641c00083a3489
😎 Deploy Preview https://deploy-preview-2555.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
11 4.47 MB → 4.47 MB (-44 B) -0.00%
Changeset
File Δ Size
src/components/mobile/transactions/TransactionEdit.jsx 📉 -44 B (-0.14%) 30.54 kB → 30.5 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 2.55 MB → 2.55 MB (-44 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 216.88 kB 0%
static/js/BalanceWithCarryover.js 1.43 kB 0%
static/js/import.js 105.26 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/wide.js 261.12 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@joel-jeremy joel-jeremy changed the title [WIP] [Maintenance] Update onEdit to use serialized transactions [WIP] [Maintenance] Update TransactionEdit conponent onEdit function to use serialized transactions Apr 5, 2024
@joel-jeremy joel-jeremy changed the title [WIP] [Maintenance] Update TransactionEdit conponent onEdit function to use serialized transactions [Maintenance] Update TransactionEdit conponent onEdit function to use serialized transactions Apr 5, 2024
@trafico-bot trafico-bot bot added 🚧 WIP and removed 🚧 WIP labels Apr 5, 2024
@joel-jeremy joel-jeremy merged commit 2e600e5 into master Apr 6, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the cleanup-transactionedit branch April 6, 2024 21:19
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants