Display balances in category autocomplete #2551

joel-jeremy · 2024-04-04T19:34:10Z

Closes #534

netlify · 2024-04-04T19:34:23Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`84a6cf5`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/661eb6ffe860480008d8969b
😎 Deploy Preview	https://deploy-preview-2551.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-04-04T19:36:17Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.64 MB → 4.64 MB (+2.22 kB)	+0.05%

Changeset

File	Δ	Size
`src/components/autocomplete/CategoryAutocomplete.tsx`	📈 +1.22 kB (+15.34%)	7.98 kB → 9.21 kB
`src/components/modals/CategoryAutocompleteModal.tsx`	📈 +179 B (+9.47%)	1.85 kB → 2.02 kB
`src/components/budget/util.ts`	📈 +215 B (+6.65%)	3.16 kB → 3.37 kB
`src/components/accounts/Account.jsx`	📈 +1.15 kB (+2.65%)	43.41 kB → 44.56 kB
`src/components/modals/CoverModal.tsx`	📈 +31 B (+1.26%)	2.4 kB → 2.43 kB
`src/components/mobile/transactions/TransactionEdit.jsx`	📈 +228 B (+0.73%)	30.56 kB → 30.79 kB
`src/components/modals/RolloverBudgetSummaryModal.tsx`	📈 +13 B (+0.68%)	1.86 kB → 1.87 kB
`src/components/modals/TransferModal.tsx`	📈 +20 B (+0.65%)	2.99 kB → 3.01 kB
`src/components/transactions/TransactionsTable.jsx`	📈 +195 B (+0.36%)	53.13 kB → 53.32 kB
`src/components/mobile/budget/BudgetTable.jsx`	📈 +26 B (+0.08%)	30.62 kB → 30.64 kB
`src/components/Modals.tsx`	📉 -82 B (-0.56%)	14.24 kB → 14.16 kB
`src/components/modals/EditField.jsx`	📉 -986 B (-11.84%)	8.13 kB → 7.17 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/wide.js	262.74 kB → 264.08 kB (+1.34 kB)	+0.51%
static/js/index.js	2.97 MB → 2.97 MB (+872 B)	+0.03%
static/js/narrow.js	56.68 kB → 56.71 kB (+26 B)	+0.04%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/AppliedFilters.js	20.35 kB	0%
static/js/ReportRouter.js	1.19 MB	0%

github-actions · 2024-04-04T19:36:18Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.2 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.2 MB	0%

rich-howell · 2024-04-06T07:12:31Z

This is exactly what I wanted - only thing I would say is the red is really hard to read.

Teprifer · 2024-04-06T07:19:29Z

I concur, in dark and midnight themes the colours are fine, but in light even the green doesn't have good readability - especially if highlighted:

joel-jeremy · 2024-04-09T22:02:17Z

I'm frying to figure out how to make the balances available to the test which is failing. Would appreciate any tips to put me into the right direction. :)

Teprifer · 2024-04-11T07:31:23Z

Desktop contrasts are much improved, thanks :)
For the midnight theme I think the menu highlight looks too bright (to me anyway).

On mobile, light mode, category names can't be seen until highlighted:

joel-jeremy · 2024-04-12T15:12:30Z

Did a rebase, the mobile above should now be resolved. :)

MatissJanis · 2024-04-14T16:44:35Z

Small bug on desktop version:

select 2x transactions
click "2 transactions" to open the menu and then category
fatal crash

edit: same issue with 1x transaction

joel-jeremy · 2024-04-15T17:08:51Z

The batch edit bug should now be fixed :)

MatissJanis · 2024-04-16T17:22:05Z

packages/desktop-client/src/components/budget/util.ts

+  const _positiveColor = colors.positiveColor || theme.noticeText;
+  const _negativeColor = colors.negativeColor || theme.errorText;
+  const _zeroColor = colors.zeroColor || theme.tableTextSubdued;


🥜 nitpick: ‏tbh I'm not a big fan of this naming convention. I don't see it adding any value. Especially in this context.

trafico-bot bot added the 🔍 Ready for Review label Apr 4, 2024

github-actions bot changed the title ~~Display balances in category autocomplete~~ [WIP] Display balances in category autocomplete Apr 4, 2024

trafico-bot bot added 🚧 WIP and removed 🔍 Ready for Review labels Apr 4, 2024

joel-jeremy force-pushed the category-autocomplete-balances branch from dc9371f to ce4ec19 Compare April 5, 2024 17:23

joel-jeremy force-pushed the category-autocomplete-balances branch from 00919e2 to 476e0db Compare April 11, 2024 02:05

joel-jeremy force-pushed the category-autocomplete-balances branch from 4b2943e to 0f6e749 Compare April 12, 2024 15:08

joel-jeremy force-pushed the category-autocomplete-balances branch from a54479c to a8dd511 Compare April 13, 2024 19:55

joel-jeremy changed the title ~~[WIP] Display balances in category autocomplete~~ Display balances in category autocomplete Apr 13, 2024

joel-jeremy requested a review from MatissJanis April 13, 2024 20:14

trafico-bot bot added 🔍 Ready for Review and removed 🚧 WIP labels Apr 13, 2024

joel-jeremy and others added 9 commits April 14, 2024 23:10

Display balances in category autocomplete

209a03a

Release notes

c74b246

Fix typecheck error

964aed7

Update balance colors

c2079bc

Show category balances in mobile

778f715

Patch unit tests

c86e03a

Darket midnight theme autocomplete hover color

af4f713

Category autocomplete split transaction highlight

893087b

Update 2551.md

a530c58

joel-jeremy added 2 commits April 14, 2024 23:10

Extract modals from EditField

81ee131

Fix failing tests

a66886e

joel-jeremy force-pushed the category-autocomplete-balances branch from 518a9ff to a66886e Compare April 15, 2024 06:10

MatissJanis previously approved these changes Apr 16, 2024

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Apr 16, 2024

Update variable names

84a6cf5

joel-jeremy dismissed MatissJanis’s stale review via 84a6cf5 April 16, 2024 17:35

trafico-bot bot added 🔍 Ready for Review and removed ✅ Approved labels Apr 16, 2024

MatissJanis approved these changes Apr 16, 2024

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Apr 16, 2024

joel-jeremy merged commit b101f99 into master Apr 16, 2024
19 checks passed

joel-jeremy deleted the category-autocomplete-balances branch April 16, 2024 19:14

trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Apr 16, 2024

github-actions bot mentioned this pull request Apr 16, 2024

[Feature] Display category balance when assigning transaction #534

Closed

trafico-bot bot removed the ✅ Approved label Apr 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display balances in category autocomplete #2551

Display balances in category autocomplete #2551

joel-jeremy commented Apr 4, 2024

netlify bot commented Apr 4, 2024 •

edited

Loading

github-actions bot commented Apr 4, 2024 •

edited

Loading

github-actions bot commented Apr 4, 2024 •

edited

Loading

rich-howell commented Apr 6, 2024

Teprifer commented Apr 6, 2024

joel-jeremy commented Apr 9, 2024

Teprifer commented Apr 11, 2024

joel-jeremy commented Apr 12, 2024

MatissJanis commented Apr 14, 2024 •

edited

Loading

joel-jeremy commented Apr 15, 2024

MatissJanis Apr 16, 2024

Display balances in category autocomplete #2551

Display balances in category autocomplete #2551

Conversation

joel-jeremy commented Apr 4, 2024

netlify bot commented Apr 4, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Apr 4, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Apr 4, 2024 • edited Loading

Bundle Stats — loot-core

rich-howell commented Apr 6, 2024

Teprifer commented Apr 6, 2024

joel-jeremy commented Apr 9, 2024

Teprifer commented Apr 11, 2024

joel-jeremy commented Apr 12, 2024

MatissJanis commented Apr 14, 2024 • edited Loading

joel-jeremy commented Apr 15, 2024

MatissJanis Apr 16, 2024

Choose a reason for hiding this comment

netlify bot commented Apr 4, 2024 •

edited

Loading

github-actions bot commented Apr 4, 2024 •

edited

Loading

github-actions bot commented Apr 4, 2024 •

edited

Loading

MatissJanis commented Apr 14, 2024 •

edited

Loading