Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing import of reconciled split transactions #2543

Conversation

davidkus
Copy link
Contributor

@davidkus davidkus commented Apr 2, 2024

When importing transactions from nYNAB, I noticed that for reconciled split transactions, the "child" transactions were not being marked as reconciled after import.

Before

Screen.Recording.2024-04-02.at.7.02.02.PM.mov

After

Screen.Recording.2024-04-02.at.7.01.24.PM.mov

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0bba26d
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/660c92b6b640a40008d51445
😎 Deploy Preview https://deploy-preview-2543.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
11 4.45 MB → 4.45 MB (+76 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +76 B (+1.17%) 6.37 kB → 6.44 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.54 MB → 2.54 MB (+76 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 215.48 kB 0%
static/js/BalanceTooltip.js 7.31 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/import.js 105.26 kB 0%
static/js/wide.js 249 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB → 1.2 MB (+54 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/shared/transactions.ts 📈 +80 B (+0.96%) 8.16 kB → 8.24 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.2 MB → 1.2 MB (+54 B) +0.00%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@davidkus davidkus marked this pull request as ready for review April 2, 2024 23:23
@youngcw youngcw merged commit 8b34ba3 into actualbudget:master Apr 4, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants