Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/hide reconciled transactions in the account view #2542

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

davidkus
Copy link
Contributor

@davidkus davidkus commented Apr 2, 2024

Adds toggle to show/hide reconciled transactions in the account view.
This functions similar to how it works in YNAB:

  1. Setting is stored in local prefs (persisted between refresh)
  2. Setting is per-account

edit:
Just some more context on this:

I had previously added a filter for reconciled transactions in #2108. But this doesn't really work as I'd want it (and other people have requested). Really what we want is for this to persist, and behave like the YNAB "view" for hiding reconciled transactions (e.g. still show scheduled transactions).

Screen.Recording.2024-04-02.at.6.19.10.PM.mov

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6cb9434
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/660d8c0c242b290008a6071b
😎 Deploy Preview https://deploy-preview-2542.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
11 4.45 MB → 4.45 MB (+1.12 kB) +0.02%
Changeset
File Δ Size
src/components/accounts/Account.jsx 📈 +945 B (+2.19%) 42.16 kB → 43.08 kB
src/components/accounts/Header.jsx 📈 +206 B (+1.45%) 13.9 kB → 14.1 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 249 kB → 250.13 kB (+1.12 kB) +0.45%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 215.48 kB 0%
static/js/BalanceTooltip.js 7.31 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/import.js 105.26 kB 0%
static/js/ReportRouter.js 1.18 MB 0%
static/js/index.js 2.54 MB 0%

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@youngcw
Copy link
Member

youngcw commented Apr 2, 2024

This is looking pretty good. I noticed that if you have locked hidden, then add a filter, then show locked transactions again, that the filter no longer applies correctly.

@davidkus
Copy link
Contributor Author

davidkus commented Apr 2, 2024

This is looking pretty good. I noticed that if you have locked hidden, then add a filter, then show locked transactions again, that the filter no longer applies correctly.

Good catch, should be fixed with latest commit.

@davidkus davidkus marked this pull request as ready for review April 2, 2024 22:52
Copy link
Contributor

@joel-jeremy joel-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youngcw youngcw merged commit 66dc593 into actualbudget:master Apr 4, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants