-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show/hide reconciled transactions in the account view #2542
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
This is looking pretty good. I noticed that if you have locked hidden, then add a filter, then show locked transactions again, that the filter no longer applies correctly. |
Good catch, should be fixed with latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds toggle to show/hide reconciled transactions in the account view.
This functions similar to how it works in YNAB:
edit:
Just some more context on this:
I had previously added a filter for reconciled transactions in #2108. But this doesn't really work as I'd want it (and other people have requested). Really what we want is for this to persist, and behave like the YNAB "view" for hiding reconciled transactions (e.g. still show scheduled transactions).
Screen.Recording.2024-04-02.at.6.19.10.PM.mov