Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When starting input with operator, append to existing value instead of replacing #2523

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

JazzyJosh
Copy link
Contributor

@JazzyJosh JazzyJosh commented Mar 30, 2024

Implements #2315

Happy for any feedback on this PR, or warnings of any issues I might have overlooked. Would add a test but not quite sure if this is worth an end to end add.

Release note upcoming.

Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 3cdfc55
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6613425ed96cd70008cb5f61
😎 Deploy Preview https://deploy-preview-2523.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot changed the title When starting input with operator, append to existing value instead of replacing [WIP] When starting input with operator, append to existing value instead of replacing Mar 30, 2024
Copy link
Contributor

github-actions bot commented Mar 30, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.48 MB → 4.48 MB (+326 B) +0.01%
Changeset
File Δ Size
src/components/table.tsx 📈 +326 B (+1.33%) 23.88 kB → 24.2 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.56 MB → 2.56 MB (+326 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/BalanceWithCarryover.js 1.43 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/import.js 105.26 kB 0%
static/js/narrow.js 216.9 kB 0%
static/js/wide.js 262.04 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

github-actions bot commented Mar 30, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@JazzyJosh JazzyJosh marked this pull request as draft March 30, 2024 00:44
@JazzyJosh JazzyJosh force-pushed the feature/arithmatic-input branch 3 times, most recently from 97a2dc0 to 26461a1 Compare March 30, 2024 13:57
@JazzyJosh JazzyJosh marked this pull request as ready for review March 30, 2024 13:57
@youngcw
Copy link
Member

youngcw commented Apr 1, 2024

Nice. Can you add a release note

@JazzyJosh
Copy link
Contributor Author

JazzyJosh commented Apr 1, 2024 via email

@youngcw
Copy link
Member

youngcw commented Apr 1, 2024

oh, looks like the note just has a formatting issue

@youngcw
Copy link
Member

youngcw commented Apr 2, 2024

If you are ready for this to get reviewed remove the [WIP] label from the title, and also if you could fix that issue with the release note. All probably is ready after that.

@JazzyJosh
Copy link
Contributor Author

JazzyJosh commented Apr 2, 2024 via email

@JazzyJosh JazzyJosh force-pushed the feature/arithmatic-input branch from 26461a1 to 3cdfc55 Compare April 8, 2024 01:03
@JazzyJosh JazzyJosh changed the title [WIP] When starting input with operator, append to existing value instead of replacing When starting input with operator, append to existing value instead of replacing Apr 8, 2024
@youngcw youngcw merged commit a955fe2 into actualbudget:master Apr 10, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 10, 2024
@JazzyJosh JazzyJosh deleted the feature/arithmatic-input branch August 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants